add nice-dcv support

[Mitchell Dzurick]

Please backport nice-dcv support for gnome-shell in Focal. Work has been done to enable this in gitlab - https://gitlab.gnome.org/abono/gnome-shell/-/commits/wip/abono/ubuntu-20-04-gnome-3-36-9-backports

[Daniel van Vugt (vanvugt)]

I think focal support would be getting ahead of ourselves. What backported from where? The only commit in that tree that mentions "Dcv" doesn't exist in gnome-shell upstream yet.

Do you mean these?

https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2399
https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2411

[Mitchell Dzurick (mitchdz)]

The gitlab link I provided has relevant changes to enable nice-dcv in our focal package for gnome-shell. We actually only need 2 commits from that branch.

ubuntu/focal-devel already has the following commits as patches
* authPrompt: Properly get oVirt service name
* gdm: Refactor oVirt to a generic CredentialManager interface

Therefore to enable this feature we would only need to include these patches

* loginDialog: Don't call _loginScreenSessionActivated() when not required
  - https://gitlab.gnome.org/abono/gnome-shell/-/commit/596a56ab737a64b5d3fbc9963b1fce83dbe40685
* gdm: Add DcvCredentialsManager
  - https://gitlab.gnome.org/abono/gnome-shell/-/commit/fc41bb13ba0c671ec7df8412940a19f276b86079

[Daniel van Vugt (vanvugt)]

> * loginDialog: Don't call _loginScreenSessionActivated() when not required
> - https://gitlab.gnome.org/abono/gnome-shell/-/commit/596a56ab737a64b5d3fbc9963b1fce83dbe40685

Since that's in gnome-shell 43.0 already it can be backported to 42.x yes...

> * gdm: Add DcvCredentialsManager
> - https://gitlab.gnome.org/abono/gnome-shell/-/commit/fc41bb13ba0c671ec7df8412940a19f276b86079

That's not in any gnome-shell branch yet. Not even main. It says "Copyright Amazon.com" but is also licensed as GPL so we can use it in theory. I recommend you contact https://gitlab.gnome.org/abono who seems to work for Amazon, and ask him about when it might be ready to be proposed for merging into main.

After both commits exist in gnome-shell main we can consider backports.

[Daniel van Vugt (vanvugt)]

Incomplete because this feature request can never be actioned in Ubuntu until the feature exists in upstream gnome-shell first.

[Launchpad Janitor (janitor)]

[Expired for gnome-shell (Ubuntu) because there has been no activity for 60 days.]