FreezeException request-- Sync with Debian unstable

Bug #201941 reported by Matt Arnold
8
Affects Status Importance Assigned to Milestone
inspircd (Ubuntu)
Fix Released
Wishlist
Unassigned

Bug Description

Binary package hint: inspircd

Hello,

 I request a Feature Freeze Exception for inspircd in order to sync with Debian unstable. Inspircd has many large bugs and security holes fixed in 1.1.17.

There is also a serious packaging bug in the 1.1.15 package which prevents the removal or upgrade of inspircd.

Some of the security and bug fixes include:

- bug #458: servers go missing on collision (functionality issue)

- when an oper is on a notify list and the oper sets +Q, then the watch list for that user goes into an undefined state , due to the metadata not being correctly cleared from the user in m_watch OnUserQuit (crash/security).

 As this is also a sync request i'm including the Debian changelog as well as the usual stuff. As a final note upstreams changelogs are not in diff friendly format so i have included the entry for 1.1.17.

Regards
Matt

Upstream Changelog

The key changes are that users will now quit faster (e.g. in netsplits, glines, etc), Windows should no longer have weird problems with "ghost" users and high CPU use.

K|G|Z|E:Line can now also be used on a nickname - e.g. /zline w00t 1d :foo would place an IP ban on my IP for one day.

A low risk crash with m_invisible and m_watch was also fixed.

Other miscellaneous fixes are also included, see the changelog (below) for full details.

I'd like to thank everyone who helped with QA for their time and effort - here's hoping the process continues to be as effective.

    * Fix: trying to send out all lines in one hit is different from the way we do users, etc - and also won't be too healthy for the socket buffer with lots of them. This also removes a data copy, which in theory will make it fractionally faster. Fixes bug #496 reported by Skip.
    * Manually merge patch from danieldg, thanks
    * Make select socketengine build on vs80
    * Fix oper quit messages (needed to be set to regular quit if empty) - same fix may apply to 1.2..?
    * Backport reworked culllist from 1.2: drastically improves performance when quitting a lot of users (e.g. on netsplit). I was originally not going to do this for 1.1, but it seems to perform well, and I can't break it under clone flooding - so in it goes. QA: please test this with lots of activity (connecting, disconnecting, ping timeouts, socket errors, anything you can throw at it)
    * K|G|Z|ELine fix, from 8901
    * Don't declare a dupe InspIRCd *
    * Set FD_SETSIZE to 12000, this allows 12000 users per ircd rather than 64. I doubt select can scale this high, but 64 is rediculous.
    * Commit stuff from fez that he couldnt get committed - fixes to make socketengine-select work in windows (should be more stable than iocp as the api is known to us unix devs)
    * Rewrite nick targeted bans to user@host or IP bans where necessary. I don't know why this didn't happen already.
    * Backport r8866: make K|G|Z|ELine actually work with a nickname target (code was there but not functional)
    * Backport low risk memory leak fix to m_cgiirc (r8852)
    * MODEACTION_ALLOW was being used instead of DENY, fixes bug #490
    * Probably fix a crash in randquote (it does for me)
    * Backport r8810: minor FTOPIC desync fix
    * Backport r8786 from dz: closes bug #391
    * Merge in patches to fix bug #487, submitted by dz, thanks
    * Update SAMODE
    * Apply patch from bug #484 written by John. In 1.1 this applies without modification, thanks
    * Check that exec() macros havent failed before commencing build
    * Backport: Fix for bug found by eLement, when an oper is on a notify list and the oper sets +Q, then the watch list for that user goes into an undefined state , due to the metadata not being correctly cleared from the user in m_watch OnUserQuit. Thanks

Debian Changelog:

 inspircd (1.1.17+dfsg-1) unstable; urgency=low

   [ Darren Blaber ]
   * New upstream release, fix /etc/init.d/inspircd stop.
   * Fix the postrm script so there is no duplicate update-rc.d
   * Fix the manpage so there are no more errors in it

   [ Matt Arnold ]
   * Fix prerm so it works (Closes: #466924)

   [ Giacomo Catenazzi ]
   * Added me as uploader
   * Add again support of dpatch in debian/rules
   * Build sources only once!
   * Correct make clean target, not to include generated ./inspircd on sources
   * Don't change permission of configuration files, when starting inspircd
     (separation of policy and program).

 -- Giacomo Catenazzi <email address hidden> Thu, 06 Mar 2008 07:56:47 +0100

Revision history for this message
Matt Arnold (mattarnold5) wrote :
Revision history for this message
Matt Arnold (mattarnold5) wrote :
Revision history for this message
Scott Kitterman (kitterman) wrote :

What security fixes are in this?

Revision history for this message
Matt Arnold (mattarnold5) wrote :

 when an oper is on a notify list and the oper sets +Q, then the watch list for that user goes into an undefined state , due to the metadata not being correctly cleared from the user in m_watch OnUserQuit (crash/security).

Revision history for this message
Scott Kitterman (kitterman) wrote : Re: [Bug 201941] Re: FreezeException request-- Sync with Debian unstable

Ack from me.

Revision history for this message
Cesare Tirabassi (norsetto) wrote :

>There is also a serious packaging bug in the 1.1.15 package which prevents
>the removal or upgrade of inspircd.

In 1.1.16, not in 1.1.15 (which is the version we have in hardy), what are the changes between 1.1.15 and 1.1.16?

Revision history for this message
Matt Arnold (mattarnold5) wrote :

That packaging bug was still presant in .16 but as you wish

1.1.16-parmesan

# Backport <goodchan>: Explicitly allow channels denied by <badchan>
# Backport fix for bug #464 reported by John
# Rebind server sockets on REHASH, closes bug #478
# Update conf (patch from bug #463, thanks John)
# Backport r8661: don't send 421 to unregistered clients (thanks nenolod)
# I swear I've fixed this 5 times now.. it's PERMANENT, USE A DICTIONARY http://dictionary.reference.com/browse/Permanent
# Backport r8651: SHA256 consistancy fix.
# Backport 8634, fix for bug #464 reported by John
# Fix for bug #458: servers go missing on collision etc.
# Manual backport of r8613: remove nuh mask from /clones output
# Backport --disable-rpath configure option for package maintainers
# The mysql worker thread only sleeps 50 nanosecs between cycles, this is not enough to prevent it chomping on the CPU on most machines., Increase to 1000, fixes bugs noticed on forum by JulianD, thanks

Revision history for this message
Luke Yelavich (themuso) wrote :

Ok, this seems like a worthwhile update, ack from me. Go ahead and request sponsorship for the sync.

Changed in inspircd:
status: New → Confirmed
Revision history for this message
Steve Langasek (vorlon) wrote :

"request sponsorship for the sync" -> ubuntu-universe-sponsors; this appears to still need confirmation by a MOTU for the correctness of the upload (as distinct from the freeze exception).

Changed in inspircd:
importance: Undecided → Wishlist
status: Confirmed → New
Revision history for this message
StefanPotyra (sistpoty) wrote :

sponsors ack. builds fine, works.

Changed in inspircd:
status: New → Confirmed
Revision history for this message
Martin Pitt (pitti) wrote :

Getting binaries for hardy...
[Updating] inspircd (1.1.15+dfsg-1 [Ubuntu] < 1.1.17+dfsg-1 [Debian])
 * Trying to add inspircd...
  - <inspircd_1.1.17+dfsg.orig.tar.gz: downloading from http://ftp.debian.org/debian/>
  - <inspircd_1.1.17+dfsg-1.dsc: downloading from http://ftp.debian.org/debian/>
  - <inspircd_1.1.17+dfsg-1.diff.gz: downloading from http://ftp.debian.org/debian/>
I: inspircd [universe] -> inspircd_1.1.15+dfsg-1 [universe].
I: inspircd [universe] -> inspircd-dbg_1.1.15+dfsg-1 [universe].

Changed in inspircd:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.