On shutdown, linuxbridge agent queue on rabbitmq is not cleared

[StreSS.t]

This bug mimics https://bugs.launchpad.net/oslo.messaging/+bug/1606213.

In that bug, the path to oslo_messaging was added, but the close method was not called in the linuxbridge agent

Example patch:

--- /usr/lib/python3/dist-packages/neutron/plugins/ml2/drivers/agent/_common_agent.py.bak 2023-05-12 11:45:42.089121033 +0000
+++ /usr/lib/python3/dist-packages/neutron/plugins/ml2/drivers/agent/_common_agent.py 2023-05-12 11:46:08.201490083 +0000
@@ -116,6 +116,7 @@
         if graceful and self.quitting_rpc_timeout:
             self.set_rpc_timeout(self.quitting_rpc_timeout)
         super(CommonAgentLoop, self).stop(graceful)
+ self.connection.close()

     def reset(self):
         common_config.setup_logging()

[Mamatisa Nurmatov (isabek)]

 CommonAgentLoop also used in ovs agent and macvtap agent

[StreSS.t (stress-t)]

Yes. I can't find the correct object for the linuxbridge agent. maybe someone will find the right object and provide the best patch

[Rodolfo Alonso (rodolfo-alonso-hernandez)]

Hello:

The OVS agent uses its own loop and doesn't rely on ``CommonAgentLoop`` class. The OVS agent class is ``OVSNeutronAgent``.

This issue reported in ``CommonAgentLoop`` is affecting only LB and MacVTap.

Regards.

[Rodolfo Alonso (rodolfo-alonso-hernandez)]

In fact, the OVS agent does stop the RPC connections (in order):
* https://github.com/openstack/neutron/blob/181177fe885f49f2d31f3e175d33efbf21ac3676/neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py#L2865-L2866
* https://github.com/openstack/neutron/blob/181177fe885f49f2d31f3e175d33efbf21ac3676/neutron/agent/rpc.py#L403
* https://github.com/openstack/neutron/blob/181177fe885f49f2d31f3e175d33efbf21ac3676/neutron/agent/resource_cache.py#L53
* https://github.com/openstack/neutron/blob/181177fe885f49f2d31f3e175d33efbf21ac3676/neutron/agent/resource_cache.py#L271

As commented, this is affecting only these agents using ``CommonAgentLoop``.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/883685

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/884004

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Lajos Katona <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/884004
Reason: https://review.opendev.org/c/openstack/neutron/+/883685 was quicker

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/883685
Committed: https://opendev.org/openstack/neutron/commit/050536c66e4f8cdc6c7aa3ff77c0e9995db5717a
Submitter: "Zuul (22348)"
Branch: master

commit 050536c66e4f8cdc6c7aa3ff77c0e9995db5717a
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Fri May 19 16:52:16 2023 +0000

    Stop the RPC connections when the agent exits

    This behaviour is already present in the OVS agent RPC plugin;
    this patch is imitating that in the ``CommonAgentLoop`` class.

    Closes-Bug: #2019314
    Change-Id: I8c87e5ff7b948455c62e2fa2a3c89b8b1e45875c

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 23.0.0.0b3 development milestone.