rtl8821ce should not build when CONFIG_CFG80211 is not enabled for linux-kvm
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| rtl8821ce (Ubuntu) |
Confirmed
|
Undecided
|
Unassigned | ||
| Jammy |
Fix Committed
|
Undecided
|
Roxana Nicolescu | ||
Bug Description
[SRU Justification]
Impact:
jammy:linux-kvm does not have CONFIG_CFG80211 enabled.
Module rtl8821ce-dkms requires it, otherwise, build will fail.
Before last update to 5.5.2.1-
# Only build on wifi enabled kernels
if ! grep -q '^CONFIG_
BUILD_EXCLUSIVE
fi
But the new version broke it because the rule that was overridden by
BUILD_EXCLUSIVE
This lead to new regression in autopkgtest for jammy:linux-
Fix:
Add an if else condition so it will cover 2 cases:
1. package won't build if kernel does not have CONFIG_CFG80211 enabled
2. if 1 is true, package won't build if kernel version is not 5.15.
Test plan:
autopkgtest rtl8821ce fails during build with the error from below
...
ERROR: modpost: "cfg80211_
ERROR: modpost: "cfg80211_
ERROR: modpost: "wiphy_
ERROR: modpost: "__cfg80211_
ERROR: modpost: "cfg80211_new_sta" [/var/lib/
ERROR: modpost: "cfg80211_
ERROR: modpost: "cfg80211_
ERROR: modpost: "cfg80211_
ERROR: modpost: "cfg80211_put_bss" [/var/lib/
ERROR: modpost: "cfg80211_roamed" [/var/lib/
WARNING: modpost: suppressed 18 unresolved symbol warnings because there were too many)
make[2]: *** [scripts/
make[2]: *** Deleting file '/var/lib/
make[1]: *** [Makefile:1821: modules] Error 2
make[1]: Leaving directory '/usr/src/
make: *** [Makefile:2262: modules] Error 2
=======
./rtl8821ce/
autopkgtest [02:46:16]: test dkms-autopkgtest: -------
dkms-autopkgtest FAIL non-zero exit status 1
autopkgtest [02:46:17]: test dkms-autopkgtest: - - - - - - - - - - results - - - - - - - - - -
autopkgtest [02:46:17]: @@@@@@@
dkms-autopkgtest FAIL non-zero exit status 1
Creating nova instance adt-jammy-
This happens if you run apt install rtl8821ce-dkms.
Once the fix is there:
1. module should skip build on linux-kvm or any kernel that has CONFIG_CFG80211 disabled.
2. module should build on linux-generic (5.15)
3. module should skip build on 5.19 kernels
Tested locally in a VM:
1. linux-kvm: 5.15.0-1033-kvm. Build is skipped:
ubuntu@jammy:~$ sudo dpkg -i rtl8821ce-
(Reading database ... 223166 files and directories currently installed.)
Preparing to unpack rtl8821ce-
Deleting module rtl8821ce-5.5.2.1 completely from the DKMS tree.
Unpacking rtl8821ce-dkms (5.5.2.
Setting up rtl8821ce-dkms (5.5.2.
Loading new rtl8821ce-5.5.2.1 DKMS files...
Building for 5.15.0-1033-kvm
Building initial module for 5.15.0-1033-kvm
Error! The /var/lib/
The /var/lib/
This indicates that it should not be built.
Skipped.
2. 5.15.0-57-generic. Built and installed successfully:
ubuntu@jammy:~/rtl$ sudo dpkg -i rtl8821ce-
(Reading database ... 81589 files and directories currently installed.)
Preparing to unpack rtl8821ce-
Module rtl8821ce-5.5.2.1 for kernel 5.15.0-57-generic (x86_64).
Before uninstall, this module version was ACTIVE on this kernel.
rtl8821ce.ko:
- Uninstallation
- Deleting from: /lib/modules/
- Original module
- No original module was found for this module on this kernel.
- Use the dkms install command to reinstall any previous module version.
/etc/modprobe.
depmod...
Deleting module rtl8821ce-5.5.2.1 completely from the DKMS tree.
Unpacking rtl8821ce-dkms (5.5.2.
Setting up rtl8821ce-dkms (5.5.2.
Loading new rtl8821ce-5.5.2.1 DKMS files...
Building for 5.15.0-57-generic
Building initial module for 5.15.0-57-generic
EFI variables are not supported on this system
/sys/firmware/
Done.
rtl8821ce.ko:
Running module version sanity check.
- Original module
- No original module exists within this kernel
- Installation
- Installing to /lib/modules/
/etc/modprobe.
depmod...
3. 5.19.0-1025-aws: Build is skipped.
ubuntu@jammy:~$ sudo dpkg -i rtl8821ce-
Selecting previously unselected package rtl8821ce-dkms.
(Reading database ... 99576 files and directories currently installed.)
Preparing to unpack rtl8821ce-
Unpacking rtl8821ce-dkms (5.5.2.
Setting up rtl8821ce-dkms (5.5.2.
Loading new rtl8821ce-5.5.2.1 DKMS files...
Building for 5.19.0-1025-aws
Building initial module for 5.19.0-1025-aws
Error! The /var/lib/
This indicates that it should not be built.
Skipped.
Regression potential:
None. Build is skipped so no tests are performed.
| Changed in rtl8821ce (Ubuntu Jammy): | |
| assignee: | nobody → Roxana Nicolescu (roxanan) |
| Roxana Nicolescu (roxanan) wrote | #2 |
| Launchpad Janitor (janitor) wrote | #3 |
| Changed in rtl8821ce (Ubuntu Jammy): | |
| status: | New → Confirmed |
| Changed in rtl8821ce (Ubuntu): | |
| status: | New → Confirmed |
| Timo Aaltonen (tjaalton) wrote Please test proposed package | #5 |
| Changed in rtl8821ce (Ubuntu Jammy): | |
| status: | Confirmed → Fix Committed |
| tags: | added: verification-needed verification-needed-jammy |
| Ubuntu SRU Bot (ubuntu-sru-bot) wrote Autopkgtest regression report (rtl8821ce/5.5.2.1-0ubuntu11~0.22.04.3) | #6 |
Status changed to 'Confirmed' because the bug affects multiple users.