[PostgreSQL] Issue with "get_scoped_floating_ips" query

[Rodolfo Alonso]

As reported in the Ironic CI [1], the query performed in ``FloatingIP.get_scoped_floating_ips`` is failing because of:
"""
ERROR oslo_messaging.rpc.server oslo_db.exception.DBError: (psycopg2.errors.GroupingError) column "subnetpools.address_scope_id" must appear in the GROUP BY clause or be used in an aggregate function
May 03 18:42:03.790127 np0033933847 neutron-server[90676]: ERROR oslo_messaging.rpc.server LINE 2: ...standard_attr_id AS floatingips_standard_attr_id, subnetpool...
"""

The patch that introduced the "GROUP BY" clause is [2].

Snippet: https://paste.opendev.org/show/bPxCQXpieE5G5v31xudJ/

[1]https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_291/882164/1/check/ironic-tempest-pxe_ipmitool-postgres/291f2f8/controller/logs/screen-q-svc.txt
[2]https://review.opendev.org/c/openstack/neutron/+/876168

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/882935

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/882935
Committed: https://opendev.org/openstack/neutron/commit/3b7699bc6614d0c03d55087e63c4ccd19878caa4
Submitter: "Zuul (22348)"
Branch: master

commit 3b7699bc6614d0c03d55087e63c4ccd19878caa4
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Wed May 10 06:32:32 2023 +0200

    Add scope ID to the "GROUP BY" clause in ``get_scoped_floating_ips``

    PostgreSQL requires to add the table keys selected in the SELECT clause
    in the later GROUP BY clause. This patch is adding
    "SubnetPool.address_scope_id" to this GROUP BY clause. Because the
    subnet pool (for IPv4) is unique for the FIP subnet, the returned
    elements in this query will be the same.

    Closes-Bug: #2019186
    Change-Id: Ia446e17a44b1a260971ae237841451edb97ce39f

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/neutron/+/892599

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 23.0.0.0b3 development milestone.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/892599
Committed: https://opendev.org/openstack/neutron/commit/37bdb9e7d5e719096ab6a5980c4a6da4c2f5dbbc
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit 37bdb9e7d5e719096ab6a5980c4a6da4c2f5dbbc
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Wed May 10 06:32:32 2023 +0200

    Add scope ID to the "GROUP BY" clause in ``get_scoped_floating_ips``

    PostgreSQL requires to add the table keys selected in the SELECT clause
    in the later GROUP BY clause. This patch is adding
    "SubnetPool.address_scope_id" to this GROUP BY clause. Because the
    subnet pool (for IPv4) is unique for the FIP subnet, the returned
    elements in this query will be the same.

    Conflicts:
        neutron/objects/router.py
        neutron/tests/unit/objects/test_router.py

    Closes-Bug: #2019186
    Change-Id: Ia446e17a44b1a260971ae237841451edb97ce39f
    (cherry picked from commit 3b7699bc6614d0c03d55087e63c4ccd19878caa4)