Line item checkbox IDs are numeric; need prefix

[Stephanie Leary]

Filing this separately from bug 2009092, because this won't break anything essential, but we do need to fix it: the line item checkbox IDs in the PO list are numeric. For various reasons, HTML ID attributes need to start with a letter. (See https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/id for the details.)

[id]="li.id()" should be something more like [id]="'lineitem-'+li.id()"

... however, I'm not confident I can change this here without fouling up the logic elsewhere, so I'll let someone else tackle this.

Standardizing our DOM ID attributes would help us avoid these errors; see bug 2018410.

[Stephanie Leary (stephanieleary)]

Now that I have worked with this screen a bit more, I'm pretty sure we can fix these IDs without affecting any other logic on the page. Branch: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sleary/lp2019031-lineitem-id-prefix

To test, visit any page that includes a list of line items, like a PO (/eg2/en-US/staff/acq/po/1). Inspect the checkbox next to the line item's title. You should see that it has an aria-labelledby attribute that starts with 'lineitem-', and the following <a> tag has a matching ID attribute.

[Ruth Frasur Davis (redavis)]

I have tested this fix based on Stephanie's test strategy in comment #1 and confirm that when inspecting the checkbox next to a line item in a PO, the aria-labelledby attribute starts with 'lineitem-' and the following <a> tag has a matching ID attribute.

I consent to sign off on this using my username, rfrasur, and email address, <email address hidden>.

[Terran McCanna (tmccanna)]

Thanks Stephanie and Ruth! Fix committed to main and pushed back to 3.11 (did not apply cleanly to 3.10).