neutron

Unnecessary agent resource version

Bug #2018474 reported by yaoguang
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Triaged
Low
Miguel Lavalle

Bug Description

In neutron 'rpc worker' process, RPC callback method `report_state`， there will update local 'agent resource versions' and push to another neutron ‘RPC worker’, but the neutron ‘API worker does not benefit，it always query from db and save in memory. So I don't understand the point of this mechanism. Maybe this should be deleted entirely.

Revision history for this message
Oleg Bondarev (obondarev) wrote :

Can you please add links to code where "API worker does not benefit，it always query from db and save in memory"

Changed in neutron:
status: New → Incomplete
Revision history for this message
yaoguang (yaoguang100) wrote (last edit ):

Please see 'neutron.api.rpc.handlers.resources_rpc.ResourcesPushRpcApi._push' and 'neutron.api.rpc.callbacks.version_manager.get_resource_versions' and 'neutron.db.agents_db.AgentDbMixin.get_agents_resource_versions' and 'neutron.server.wsgi_eventlet.eventlet_wsgi_server'.

The 'restful api worker' don't receive and deal RPC message, only push message to agent.

details https://opendev.org/openstack/neutron/commit/97a272a892fcf488949eeec4959156618caccae8

Revision history for this message
Oleg Bondarev (obondarev) wrote :

I think it's worth investigating for possible optimisation/cleanup

Changed in neutron:
status: Incomplete → Triaged
importance: Undecided → Low
Revision history for this message
yaoguang (yaoguang100) wrote (last edit ):

If there is any progress, hope to let me know, thank you.

Miguel Lavalle (minsel)
Changed in neutron:
assignee: nobody → Miguel Lavalle (minsel)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.