OpenStack Compute (nova)

routed networks prefilter exception due to subnets can have no segments

Bug #2018375 reported by Sylvain Bauza on 2023-05-03

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	OpenStack Compute (nova)	Fix Released	Low	Sylvain Bauza

Bug Description

Since some subnets can not have some related segments, the subnet.segment_uuid value can be None but unfortunately, the routed_networks_filter prefilter doesn't support it.

2023-05-02 22:38:10.382 12 ERROR oslo_messaging.rpc.server [req-ed1b01c5-01bd-493f-8b56-b4cb21e29f59 e416974adb7a44fd910a40b208d28e9f
d7b8b3323ea64f35adeec903c340a19e - default default] Exception during message handling: KeyError: 'segment_id'
2023-05-02 22:38:10.382 12 ERROR oslo_messaging.rpc.server Traceback (most recent call last):
2023-05-02 22:38:10.382 12 ERROR oslo_messaging.rpc.server File "/usr/lib/python3.9/site-packages/oslo_messaging/rpc/server.py", line 165, in
_process_incoming
2023-05-02 22:38:10.382 12 ERROR oslo_messaging.rpc.server res = self.dispatcher.dispatch(message)
2023-05-02 22:38:10.382 12 ERROR oslo_messaging.rpc.server File "/usr/lib/python3.9/site-packages/oslo_messaging/rpc/dispatcher.py", line 309, in
dispatch
2023-05-02 22:38:10.382 12 ERROR oslo_messaging.rpc.server return self._do_dispatch(endpoint, method, ctxt, args)
2023-05-02 22:38:10.382 12 ERROR oslo_messaging.rpc.server File "/usr/lib/python3.9/site-packages/oslo_messaging/rpc/dispatcher.py", line 229, in
_do_dispatch
2023-05-02 22:38:10.382 12 ERROR oslo_messaging.rpc.server result = func(ctxt, **new_args)
2023-05-02 22:38:10.382 12 ERROR oslo_messaging.rpc.server File "/usr/lib/python3.9/site-packages/oslo_messaging/rpc/server.py", line 241, in inner
2023-05-02 22:38:10.382 12 ERROR oslo_messaging.rpc.server return func(*args, **kwargs)
2023-05-02 22:38:10.382 12 ERROR oslo_messaging.rpc.server File "/usr/lib/python3.9/site-packages/nova/scheduler/manager.py", line 140, in
select_destinations
2023-05-02 22:38:10.382 12 ERROR oslo_messaging.rpc.server request_filter.process_reqspec(ctxt, spec_obj)
2023-05-02 22:38:10.382 12 ERROR oslo_messaging.rpc.server File "/usr/lib/python3.9/site-packages/nova/scheduler/request_filter.py", line 387, in
process_reqspec
2023-05-02 22:38:10.382 12 ERROR oslo_messaging.rpc.server filter(ctxt, request_spec)
2023-05-02 22:38:10.382 12 ERROR oslo_messaging.rpc.server File "/usr/lib/python3.9/site-packages/nova/scheduler/request_filter.py", line 41, in
wrapper
2023-05-02 22:38:10.382 12 ERROR oslo_messaging.rpc.server ran = fn(ctxt, request_spec)
2023-05-02 22:38:10.382 12 ERROR oslo_messaging.rpc.server File "/usr/lib/python3.9/site-packages/nova/scheduler/request_filter.py", line 348, in
routed_networks_filter
2023-05-02 22:38:10.382 12 ERROR oslo_messaging.rpc.server aggregates = utils.get_aggregates_for_routed_network(
2023-05-02 22:38:10.382 12 ERROR oslo_messaging.rpc.server File "/usr/lib/python3.9/site-packages/nova/scheduler/utils.py", line 1390, in
get_aggregates_for_routed_network
2023-05-02 22:38:10.382 12 ERROR oslo_messaging.rpc.server segment_ids = network_api.get_segment_ids_for_network(
2023-05-02 22:38:10.382 12 ERROR oslo_messaging.rpc.server File "/usr/lib/python3.9/site-packages/nova/network/neutron.py", line 3610, in
get_segment_ids_for_network
2023-05-02 22:38:10.382 12 ERROR oslo_messaging.rpc.server return [subnet['segment_id'] for subnet in subnets
2023-05-02 22:38:10.382 12 ERROR oslo_messaging.rpc.server File "/usr/lib/python3.9/site-packages/nova/network/neutron.py", line 3611, in <listcomp>
2023-05-02 22:38:10.382 12 ERROR oslo_messaging.rpc.server if subnet['segment_id'] is not None]
2023-05-02 22:38:10.382 12 ERROR oslo_messaging.rpc.server KeyError: 'segment_id'
2023-05-02 22:38:10.382 12 ERROR oslo_messaging.rpc.server
2023-05-02 22:38:15.178 11 DEBUG nova.scheduler.manager [req-798de5ac-273e-40fd-abce-36e701488046 e416974adb7a44fd910a40b208d28e9f
d7b8b3323ea64f35adeec903c340a19e - default default] Starting to schedule for instances: ['412ca82a-06a4-40d9-b12d-08c56a78c5a9'] select_destinations
/usr/lib/python3.9/site-packages/nova/scheduler/manager.py:124

Tags:

Sylvain Bauza (sylvain-bauza) on 2023-05-03

Changed in nova:
status:	New → Confirmed
importance:	Undecided → Low
assignee:	nobody → Sylvain Bauza (sylvain-bauza)
tags:	added: neutron scheduler

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2023-05-03: Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/nova/+/882160

Changed in nova:
status:	Confirmed → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2023-05-04: Fix merged to nova (master)

Reviewed: https://review.opendev.org/c/openstack/nova/+/882160
Committed: https://opendev.org/openstack/nova/commit/6d7bd6a03446d5227d515b2b4c0da632ef4aa4a1
Submitter: "Zuul (22348)"
Branch: master

commit 6d7bd6a03446d5227d515b2b4c0da632ef4aa4a1
Author: Sylvain Bauza <email address hidden>
Date: Wed May 3 17:00:14 2023 +0200

Fix get_segments_id with subnets without segment_id

Unfortunatly when we merged Ie166f3b51fddeaf916cda7c5ac34bbcdda0fd17a we
forgot that subnets can have no segment_id field.

Change-Id: Idb35b7e3c69fe8efe498abe4ebcc6cad8918c4ed
Closes-Bug: #2018375

Changed in nova:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2023-05-04: Fix proposed to nova (stable/2023.1)

Fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/nova/+/882293

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2023-05-16: Fix merged to nova (stable/2023.1)

Reviewed: https://review.opendev.org/c/openstack/nova/+/882293
Committed: https://opendev.org/openstack/nova/commit/6b8d9d419170fb0ec2c6df561a0874e6362382c1
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit 6b8d9d419170fb0ec2c6df561a0874e6362382c1
Author: Sylvain Bauza <email address hidden>
Date: Wed May 3 17:00:14 2023 +0200

Fix get_segments_id with subnets without segment_id

Unfortunatly when we merged Ie166f3b51fddeaf916cda7c5ac34bbcdda0fd17a we
forgot that subnets can have no segment_id field.

    Change-Id: Idb35b7e3c69fe8efe498abe4ebcc6cad8918c4ed
    Closes-Bug: #2018375
    (cherry picked from commit 6d7bd6a03446d5227d515b2b4c0da632ef4aa4a1)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2023-05-22: Fix proposed to nova (stable/zed)

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/nova/+/883723

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2023-05-22: Fix proposed to nova (stable/yoga)

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/nova/+/883724

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2023-05-22: Fix proposed to nova (stable/xena)

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/nova/+/883725

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2023-05-22: Fix proposed to nova (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/nova/+/883726

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2023-05-31: Fix merged to nova (stable/zed)

Reviewed: https://review.opendev.org/c/openstack/nova/+/883723
Committed: https://opendev.org/openstack/nova/commit/77db64237b23050d94df113a38412c5333d23357
Submitter: "Zuul (22348)"
Branch: stable/zed

commit 77db64237b23050d94df113a38412c5333d23357
Author: Sylvain Bauza <email address hidden>
Date: Wed May 3 17:00:14 2023 +0200

Fix get_segments_id with subnets without segment_id

Unfortunatly when we merged Ie166f3b51fddeaf916cda7c5ac34bbcdda0fd17a we
forgot that subnets can have no segment_id field.

    Change-Id: Idb35b7e3c69fe8efe498abe4ebcc6cad8918c4ed
    Closes-Bug: #2018375
    (cherry picked from commit 6d7bd6a03446d5227d515b2b4c0da632ef4aa4a1)
    (cherry picked from commit 6b8d9d419170fb0ec2c6df561a0874e6362382c1)