Wishlist: Copy/Item Alerts Type Default

Bug #2017673 reported by Elizabeth Davis
20
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Wishlist
Unassigned

Bug Description

Most SPARK libraries tend to only use the 2 or 3 Copy/Item Alerts when cataloging. These tend to be the ones at the bottom of the list. It would be helpful to be able to set a default Item Alert Type in the Preferences tab of the Holdings Editor screen.

description: updated
summary: - Wishlist: Copy/Item Alerts Favorites
+ Wishlist: Copy/Item Alerts Type Default
description: updated
Elaine Hardy (ehardy)
Changed in evergreen:
status: New → Confirmed
Changed in evergreen:
importance: Undecided → Wishlist
assignee: nobody → Jane Sandberg (sandbergja)
tags: added: cat-itemalerts
Revision history for this message
Jane Sandberg (sandbergja) wrote :

Here is a branch that implements this feature: user/sandbergja/lp2017673-item-alert-type-default

Here is a link: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sandbergja/lp2017673-item-alert-type-default

You can run the automated test with `cd Open-ILS/src/eg2 && npm i && npx nightwatch nightwatch/src/staff/cat/holdings-editor-config.spec.ts`

And here are some manual testing notes from the commit message:

1. Open your favorite bib record in the angular staff catalog
2. In the item table, choose an item and press Edit
3. Open the Preferences Tab
4. Under the Item Attribute Settings heading, select your favorite item alert type as the default
5. Open the Item Attributes tab.
6. Press the Item Alerts button.
7. Note that your favorite item alert type is now the default.
8. Add various alerts, with a variety of alert types.
9. Press the Apply Changes button.
10. Press the "Apply All, Save & Exit" button
11. Press Edit again
12. Press the Item Alerts button again.
13. Confirm that the correct item alert types are listed.

Changed in evergreen:
milestone: none → 3.12-beta
tags: added: pullrequest
Changed in evergreen:
assignee: Jane Sandberg (sandbergja) → nobody
Revision history for this message
Terran McCanna (tmccanna) wrote :

Jane, I'm getting a conflict on utils.ts when I try to apply to main today. Can you please rebase?

tags: added: needsrebase
Revision history for this message
Jane Sandberg (sandbergja) wrote :
tags: removed: needsrebase
Changed in evergreen:
assignee: nobody → Terran McCanna (tmccanna)
Revision history for this message
Terran McCanna (tmccanna) wrote :

I tested this (thanks for the excellent step-by-step testing instructions!) and it works great!

Fix committed to main for inclusion in 3.12.

I have two small quibbles, which I will add follow up bugs for:

1) If you try to add item alerts via the Item Status page (which is still in AngularJS), it does not recognize the default.

2) When setting the default the list of options only appears after you start typing so you have to have somewhat of an idea what it is called. Ideally, the full list should appear immediately and then be filtered down by typing.

Changed in evergreen:
status: Confirmed → Fix Committed
tags: added: signedoff
removed: wishlist
Changed in evergreen:
assignee: Terran McCanna (tmccanna) → nobody
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.