Train - PingTestGatewayIPsMap will never have ctlplane gateways

[Harald Jensås]

We never set [Networks, net_attributes_map, ctlplane] in Train. The PingTestGatewayIPsMap tries to use that information but it will always result in 'null' since the data is never set in net_attributes_map.

There is a missing backport: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/753282

The PingTestGatewayIPsMap[1] which is the fix for RHBZ#1875962 tries to get the ctlplane gateways.

overcloud.j2.yaml#L1111
 {get_attr: [Networks, net_attributes_map, ctlplane, subnets, {get_param: {{role.name}}ControlPlaneSubnet}, gateway_ip]}

However, we never set anything for the ctlplane in Train so that would return "null" which does not create an error since null is filtered in the YAQL on overcloud.j2.yaml#L1109.

[1] https://opendev.org/openstack/tripleo-heat-templates/src/branch/stable/train/overcloud.j2.yaml#L1105-L1111

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/881452
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/29ef127f96f24448cfdcd36fe3c94bc8a4ec1843
Submitter: "Zuul (22348)"
Branch: stable/train

commit 29ef127f96f24448cfdcd36fe3c94bc8a4ec1843
Author: Harald Jensås <email address hidden>
Date: Tue Sep 22 12:50:04 2020 +0200

    Add ctlplane network attrs to Networks resource output

    Add the attributes of ctlplane network and subnets to
    the output of the Networks resource.

    The ctlplane attributes are added to the plan environment
    by the depends-on tripleoclient change.

    NOTE: This is a partial backport - it does not include setting
          'ctlplane_mtu' in group_vars.

    Closes-Bug: #2017636
    Depends-On: https://review.opendev.org/825689
    Change-Id: Ic1772b384ad5b2003563b4e3d41a4a2f0e82f8e6
    (cherry picked from commit 7e9a07212b4710077d63ae031379c1b8d9a69055)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates train-eol release.