[ovn-octavia-provider] batch member update generates out of sync with Octavia DB

[Fernando Royo]

When a batch_update_members request [1] is sending not supported options (e.g. monitor_X) over a member already existing or a new one the OVN-provider applies the rest of changes for other members and skip the member with the not supported option. For each action executed (create/delete/update) an updated status is sent to Octavia API, and for the skipped members and UnsupportedOptionError is replied.

The weird thing here is that Octavia API is not applying the other member changes a soon as it receives the UnsupportedOptionError update status for the skipped member, and at this way we are generating a out of sync between the info in Octavia DB and the OVN NB DB side.

A reproducer is logged in https://paste.openstack.org/show/bU4o2ylJOg7XLXgVXKps/

[1] https://docs.openstack.org/api-ref/load-balancer/v2/?expanded=update-a-member-detail,list-pools-detail,create-pool-detail,batch-update-members-detail#batch-update-members

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/881198

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/881198
Committed: https://opendev.org/openstack/ovn-octavia-provider/commit/5f27384805bd2dd50602d3656d5f5df6c284f897
Submitter: "Zuul (22348)"
Branch: master

commit 5f27384805bd2dd50602d3656d5f5df6c284f897
Author: Fernando Royo <email address hidden>
Date: Fri Apr 21 10:14:50 2023 +0200

    Discard batch-update-members not valid request

    An out of sync has been identified between the changes applied
    over the OVN NB DB and Octavia DB when a batch-update-members
    includes some unsupported option for any of the member to be
    modified.

    To prevent such inconsistencies, this patch rejects the entire
    request if any of the proposed changes are identified as
    unsupported. The user will be notified of the reason for the
    rejection.

    Closes-Bug: 2017216
    Change-Id: I6e132ab5c23c9c53176612f74bb500e46c89024f

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/884696

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/884697

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/884698

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/884699

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/884700

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/884696
Committed: https://opendev.org/openstack/ovn-octavia-provider/commit/125ffe72c5e7ac33b5fdd8386dffea2ccc3392da
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit 125ffe72c5e7ac33b5fdd8386dffea2ccc3392da
Author: Fernando Royo <email address hidden>
Date: Fri Apr 21 10:14:50 2023 +0200

    Discard batch-update-members not valid request

    An out of sync has been identified between the changes applied
    over the OVN NB DB and Octavia DB when a batch-update-members
    includes some unsupported option for any of the member to be
    modified.

    To prevent such inconsistencies, this patch rejects the entire
    request if any of the proposed changes are identified as
    unsupported. The user will be notified of the reason for the
    rejection.

    Closes-Bug: 2017216
    Change-Id: I6e132ab5c23c9c53176612f74bb500e46c89024f
    (cherry picked from commit 5f27384805bd2dd50602d3656d5f5df6c284f897)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/884697
Committed: https://opendev.org/openstack/ovn-octavia-provider/commit/36d507ec5285bd94d63e8175237a9ebcaee1d4ff
Submitter: "Zuul (22348)"
Branch: stable/zed

commit 36d507ec5285bd94d63e8175237a9ebcaee1d4ff
Author: Fernando Royo <email address hidden>
Date: Fri Apr 21 10:14:50 2023 +0200

    Discard batch-update-members not valid request

    An out of sync has been identified between the changes applied
    over the OVN NB DB and Octavia DB when a batch-update-members
    includes some unsupported option for any of the member to be
    modified.

    To prevent such inconsistencies, this patch rejects the entire
    request if any of the proposed changes are identified as
    unsupported. The user will be notified of the reason for the
    rejection.

    Closes-Bug: 2017216
    Change-Id: I6e132ab5c23c9c53176612f74bb500e46c89024f
    (cherry picked from commit 5f27384805bd2dd50602d3656d5f5df6c284f897)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/884698
Committed: https://opendev.org/openstack/ovn-octavia-provider/commit/519a663e33cb243bf5de519cc9d765f86ae02178
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit 519a663e33cb243bf5de519cc9d765f86ae02178
Author: Fernando Royo <email address hidden>
Date: Fri Apr 21 10:14:50 2023 +0200

    Discard batch-update-members not valid request

    An out of sync has been identified between the changes applied
    over the OVN NB DB and Octavia DB when a batch-update-members
    includes some unsupported option for any of the member to be
    modified.

    To prevent such inconsistencies, this patch rejects the entire
    request if any of the proposed changes are identified as
    unsupported. The user will be notified of the reason for the
    rejection.

    Closes-Bug: 2017216
    Change-Id: I6e132ab5c23c9c53176612f74bb500e46c89024f
    (cherry picked from commit 5f27384805bd2dd50602d3656d5f5df6c284f897)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/884700
Committed: https://opendev.org/openstack/ovn-octavia-provider/commit/ac02f33f83c9bea0a912594c79b464ebe3b92192
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit ac02f33f83c9bea0a912594c79b464ebe3b92192
Author: Fernando Royo <email address hidden>
Date: Fri Apr 21 10:14:50 2023 +0200

    Discard batch-update-members not valid request

    An out of sync has been identified between the changes applied
    over the OVN NB DB and Octavia DB when a batch-update-members
    includes some unsupported option for any of the member to be
    modified.

    To prevent such inconsistencies, this patch rejects the entire
    request if any of the proposed changes are identified as
    unsupported. The user will be notified of the reason for the
    rejection.

    Closes-Bug: 2017216
    Change-Id: I6e132ab5c23c9c53176612f74bb500e46c89024f
    (cherry picked from commit 5f27384805bd2dd50602d3656d5f5df6c284f897)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/884699
Committed: https://opendev.org/openstack/ovn-octavia-provider/commit/dd6957848216c31433f4e15beb93ec82233c399a
Submitter: "Zuul (22348)"
Branch: stable/xena

commit dd6957848216c31433f4e15beb93ec82233c399a
Author: Fernando Royo <email address hidden>
Date: Fri Apr 21 10:14:50 2023 +0200

    Discard batch-update-members not valid request

    An out of sync has been identified between the changes applied
    over the OVN NB DB and Octavia DB when a batch-update-members
    includes some unsupported option for any of the member to be
    modified.

    To prevent such inconsistencies, this patch rejects the entire
    request if any of the proposed changes are identified as
    unsupported. The user will be notified of the reason for the
    rejection.

    Closes-Bug: 2017216
    Change-Id: I6e132ab5c23c9c53176612f74bb500e46c89024f
    (cherry picked from commit 5f27384805bd2dd50602d3656d5f5df6c284f897)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ovn-octavia-provider 4.0.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ovn-octavia-provider 3.1.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ovn-octavia-provider 2.1.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ovn-octavia-provider 5.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ovn-octavia-provider wallaby-eom release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ovn-octavia-provider xena-eom release.