smartmontools in Xenial does not support NVMe drives

[Ioanna Alifieraki]

[IMPACT]
smartmontools does not support NVMe drives in Xenial.
This bug is to backport basic functionality into Xenial.
The backported functionality wrt NVMe drives is what included already in Bionic.

[TEST]

smartctl commands

[REGRESSION POTENTIAL]

This feature request adds 17 commits. Although the number of the backported commits makes the regression potential high, the backported patches are pulled from upstream and mostly cherrypick. Backport, whenever needed, regards mainly the Changelog file and/or documentation files.

In addition, the patches do not touch extensively the already existing code (instead add new functionality) and therefore any regression potential would regard the new code and not the existing code base.

[OTHER]

upstream : https://svn.code.sf.net/p/smartmontools/code/trunk/smartmontools

List of upstream commits :
156286c25e9f3644cbd85d38feb910f1ad97dd69
d28c904b2d131028399e238802340f0692057e09
3c9b455b021330372a170e419a1218378c5c79fc
27a2c757685ac88e10f435d31790e27fba296ef6
783922f4b656981820fcfcac6738e87aba958fd3
d2ebf431342570c3c59df35bf8ad53b137cda821
4670f8244a1e471218bfaf04833b5f003765be56
958e73183cb6690f81b5d78cd81a9b26b3322f1c
046db21f227562e46459435fc180b9a49e1a989f
5cffe7439c03f16ef2e02cafd4b2d7843d97ac24
c3ce8eb61b421eda2eb168b53f0d47641c927f08
86df89561bc00833ace60e92d517817add761bdd
fa7e4fe72b323a180a42ccd2dc322c67eb0e30f4
3c67ac62243abde29fa8627339b6a2c32dc1b73d
7f56b42ef1f7cf77f2f7d06550eac8a5e4b4112a
19476d5f119ef1efc17dc45d764d4f994e90e1ca
ebce644805169bbee86830e2c84c9f8e12de8603

[Christian Franke (christian-franke)]

> upstream : https://github.com/smartmontools/smartmontools/

No, this is only an R/O mirror of this upstream SVN repo:

https://svn.code.sf.net/p/smartmontools/code/trunk/smartmontools

Smartmontools runs as root and performs direct pass-through device accesses. We therefore strongly discourage cherry picking of multiple non-trivial patches.

Regards,
Christian
smartmontools.org

[Ioanna Alifieraki (joalif)]

@Christian,

Thank you very much for your feedback and the correct upstream repo.
We'll take your input into consideration.