[OVN] How to deal with SB "Chassis"/"Chassis_Private" duplicated registers

Bug #2016158 reported by Rodolfo Alonso
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Wishlist
Rodolfo Alonso

Bug Description

Then UUID of the "Chassis" register is the OVS "Openvswitch.external_ids:system-id" stored value. This value is created and stored in the filesystem [1].

The "ovn-controller" process uses this OVS system-id when creating the "Chassis" register. If this system-id is changed (for example during a host upgrade), the "ovn-controller" will create a new "Chassis" register once restarted.

If by any circumstance, during this upgrade process (for example), the system-id is changed but the old "Chassis" register is not deleted from the OVN DB database by "ovn-controller" (the process is does not stop gracefully), Neutron will find two "Chassis" registers (and the corresponding "Chassis_Private") in the OVN SB database, both associated to the same host.

The question this bug is proposing is:
* Should Neutron handle this situation?
* If yes, should Neutron perform a proactive OVN SB health action?
* Should Neutron only inform to the user? (some users don't check the logs by default).

[1]https://docs.openvswitch.org/en/latest/ref/ovs-ctl.8/

Related bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2181436

Changed in neutron:
importance: Undecided → Wishlist
assignee: nobody → Rodolfo Alonso (rodolfo-alonso-hernandez)
Revision history for this message
Liu Xie (liushy) wrote :

Maybe we could process 'delete_agent' for the old agent if there is an new duplicate record when agent health check.
And there are any fileds like 'agent_type' or 'host' to ensure the agent is duplicate.

Revision history for this message
Rodolfo Alonso (rodolfo-alonso-hernandez) wrote :

Yes, this is the approach I'll take in the patch I'm going to propose but we need to make this code as safe as possible. In other words: we should delete from the OVN SB database only these registers that we consider duplicated without any doubt.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/885794

Changed in neutron:
status: New → In Progress
description: updated
Changed in neutron:
status: In Progress → Fix Committed
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 20.4.0

This issue was fixed in the openstack/neutron 20.4.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 23.0.0.0b3

This issue was fixed in the openstack/neutron 23.0.0.0b3 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 22.1.0

This issue was fixed in the openstack/neutron 22.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 21.2.0

This issue was fixed in the openstack/neutron 21.2.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron wallaby-eom

This issue was fixed in the openstack/neutron wallaby-eom release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron xena-eom

This issue was fixed in the openstack/neutron xena-eom release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.