get_sso assumes request.url.port is set

[Danny Webb]

Skyline can render invalid redirect URIs for keystone if request.url.port isn't properly rendered because a default port (eg 80/443) is used. It will create invalid redirects with :None in them.

https://opendev.org/openstack/skyline-apiserver/src/branch/master/skyline_apiserver/api/v1/login.py#L210

it can be fixed by only setting the port if it's explicitly passed, eg:

        tmp_port = f":{request.url.port}" if request.url.port else ""
        base_url = f"{url_scheme}://{request.url.hostname}{tmp_port}"

[Danny Webb (dannyswebb)]

Apologies, but it's been some while since I've used launchpad so just going to link a fix:

https://review.opendev.org/c/openstack/skyline-apiserver/+/879465

[Shuai Qian (iauhsnaiq)]

Yes we fixed it. Thanks for your reports anyway.