Fixed Fields Grid in Enhanced MARC Editor Not Updated on Save

Bug #2015163 reported by Jennifer Pringle
122
This bug affects 26 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
High
Unassigned
3.10
Fix Released
High
Unassigned
3.11
Fix Released
High
Unassigned

Bug Description

Evergreen 3.9.1
Chrome and Firefox
Angular Staff Catalogue

When editing a MARC record if you change a value like Type or BLvl in the grid section of the Enhanced MARC Editor and then click Save Changes your changes are saved and the record's format icon will be updated if needed. However, the fields that display in the grid don't change to show the now relevant fields and they often should when Type or BLvl is changed. To replicate change a record with Type = a to Type = g. (Type = g should have fifth row that include TMat, Time, and Tech).

Retrieving the record in the same tab doesn't update the grid.

To see the updated grid you have to open the record in a new tab.

The grid should update to show the relevant fields when Save Changes is clicked.

Revision history for this message
Jennifer Pringle (jpringle-u) wrote :

Could be related to https://bugs.launchpad.net/evergreen/+bug/1939882?

It certainly seems like the grid is being cached for the tab.

description: updated
Revision history for this message
Jennifer Pringle (jpringle-u) wrote :

I'm also seeing this when just viewing the Enhanced MARC Editor for different search results in the same tab. The available boxes in the grid don't change as you page through results that are different formats.

The correct grid currently only displays if you open each record in a new tab.

Revision history for this message
Katie Greenleaf Martin (kgmspark) wrote :

Confirming that this is also the case for SPARK/PaILS on our 3.9.1 installation. Refreshing the page via the browser will also trigger it to update the grid, but 'save record' does not.

Changed in evergreen:
status: New → Confirmed
Revision history for this message
Christine Morgan (cmorgan-z) wrote :

Confirmed in Chrome in 3.9.1.

To test I searched for "Harry Potter and the" to get a result set with a number of different formats. I selected a book record to view first, and then paged through the result set to view a record for a DVD and for other formats. The available boxes in the grid continued to display for the book format, though the values in the boxes did change. Opening a new tab, I selected a DVD record to view first, and saw boxes appropriate for that format. Those boxes persisted, no matter what format I look at, while paging through the result set.

I am also able to reproduce the behavior Jennifer describes when editing a MARC record.

Revision history for this message
Christine Morgan (cmorgan-z) wrote :

Same behavior also observed in 3.7.2

Revision history for this message
Jennifer Pringle (jpringle-u) wrote :

Confirmed still an issue in 3.11.1

tags: added: regression
Changed in evergreen:
assignee: nobody → Stephanie Leary (stephanieleary)
Revision history for this message
Stephanie Leary (stephanieleary) wrote :

Here's a branch with the solution Bill Erickson provided at Hack-a-way: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sleary/lp2015163-fixed-fields-refresh

To test:

1. search the catalog for something that will return results with different record types--in Concerto, I use "avenge," which gives me an Avengers DVD and the novel Throne of the Crescent Moon.
2. Go to one of the records and switch to the MARC rich editor tab. Note the layout of the fixed fields.
3. Using the prev/next buttons below the record summary box, go to the record of the next search result. The fixed fields should now have a different layout, with fields that are appropriate to the record type (e.g. the DVD will have a run time field).

Changed in evergreen:
assignee: Stephanie Leary (stephanieleary) → nobody
tags: added: pullrequest
Changed in evergreen:
milestone: none → 3.12-beta
Changed in evergreen:
assignee: nobody → Terran McCanna (tmccanna)
Revision history for this message
Terran McCanna (tmccanna) wrote :

An excellent improvement, thanks Stephanie!

Merged to main and as far back and rel_3_10.

Changed in evergreen:
status: Confirmed → Fix Committed
assignee: Terran McCanna (tmccanna) → nobody
tags: added: signedoff
Changed in evergreen:
importance: Undecided → High
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.