mesa: set info.separate_shader for ARB programs

[David Vereb]

[Impact]
There's a shader bug in 22.2.x, fixed upstream in commit

https://gitlab.freedesktop.org/mesa/mesa/-/commit/7e68cf91d74e6bd9a88c2b52417451d9afec4782

but since 22.2.x is already EOL, we need to backport it.

[Test case]

Install update, check that the application from the submitter works.

[Where things could go wrong]
This is a oneliner that flips a bool, but it's hard to imagine use-cases which would expect the old value.

--

I have a bug that occurs in Ubuntu 22.04's most up to date libmesa related packages (=22.2.5-0ubuntu0.1~22.04.1) that was not there in =22.0.1-1ubuntu2. It has since been solved in mesa's repo and pulled into debian's repo. I do not know the proper way to request an updated version be made for Ubuntu. I've manually installed many different versions of libmesa to test on my own that it was working in an older version, is broken in this update, and was fixed again in 22.3.4 and 22.3.5.

The one-line fix is implemented here in libmesa's repo: https://gitlab.freedesktop.org/mesa/mesa/-/commit/7e68cf91d74e6bd9a88c2b52417451d9afec4782

Unfortunately I'm not using libmesa directly. I'm programming an application using fox-toolkit which interfaces with libmesa behind the scenes for me. I reported my issue to them first, and they stated it appears to be in the mesa library, which is what ultimately led me down the path to their repo, debian's repo, and here. Please let me know if I'm in the right spot, and, if so, what my next step is to properly report this.

--

Feature Request: Upgrade mesa libraries to apply upstream bugfix to a bug introduced in 22.2.5-0ubuntu0.1~22.04.1.

I was directed to report this bug via my question at answers.launchpad.net/ubuntu: https://answers.launchpad.net/ubuntu/+question/705988

Please let me know if you need further information. Thanks!

 > lsb_release -rd
Description: Ubuntu 22.04.2 LTS
Release: 22.04

 > apt-cache policy libglx-mesa0
libglx-mesa0:
  Installed: 22.2.5-0ubuntu0.1~22.04.1
  Candidate: 22.2.5-0ubuntu0.1~22.04.1
  Version table:
 *** 22.2.5-0ubuntu0.1~22.04.1 500
        500 http://us.archive.ubuntu.com/ubuntu jammy-updates/main amd64 Packages
        100 /var/lib/dpkg/status
     22.0.1-1ubuntu2 500
        500 http://us.archive.ubuntu.com/ubuntu jammy/main amd64 Packages

ProblemType: Bug
DistroRelease: Ubuntu 22.04
Package: libglx-mesa0 22.2.5-0ubuntu0.1~22.04.1
ProcVersionSignature: Ubuntu 5.19.0-35.36~22.04.1-generic 5.19.17
Uname: Linux 5.19.0-35-generic x86_64
NonfreeKernelModules: zfs zunicode zavl icp zcommon znvpair
ApportVersion: 2.20.11-0ubuntu82.3
Architecture: amd64
CasperMD5CheckResult: unknown
CurrentDesktop: i3
Date: Tue Mar 28 15:30:59 2023
InstallationDate: Installed on 2022-04-28 (334 days ago)
InstallationMedia: Ubuntu 22.04 LTS "Jammy Jellyfish" - Release amd64 (20220419)
ProcEnviron:
 TERM=xterm-256color
 PATH=(custom, no user)
 XDG_RUNTIME_DIR=<set>
 LANG=en_US.UTF-8
 SHELL=/bin/bash
RebootRequiredPkgs: Error: path contained symlinks.
SourcePackage: mesa
UpgradeStatus: No upgrade log present (probably fresh install)
modified.conffile..etc.default.apport: [modified]
mtime.conffile..etc.default.apport: 2022-04-29T14:47:14.568862

[Timo Aaltonen (tjaalton)]

would've been best to just add the info from the question instead, as your request didn't even contain the link to the fix

[David Vereb (dvereb)]

Sorry about that, I thought linking the bugfix to the question would show the question post more prominently. I'll keep that in mind for next time.

Is there a way to see when this fix will make its way to the 22.04 repositories? I'm just curious how to follow along with the progress of the bugfix being applied. Is this something that's done on a schedule, or is it just when the package maintainer has time? I don't mean to rush, I'm just curious!

Thanks.

[Timo Aaltonen (tjaalton)]

one way is to wait for the lunar backport to hit jammy, but it won't happen before june/july

[Timo Aaltonen (tjaalton)]

lunar is released, so I'm skipping kinetic

[Timo Aaltonen (tjaalton)]

seems that this commit never got applied to 23.0.x while it did get in 22.3.x...

[Timo Aaltonen (tjaalton)]

it got dropped from 23.0 because:

"Causes virgl regressions, probably needs a groundwork patch in virgl"

[David Vereb (dvereb)]

The fix seems to be in 23.1 (https://gitlab.freedesktop.org/mesa/mesa/-/blob/23.1/src/mesa/program/prog_to_nir.c?ref_type=heads#L1039). For anyone else with the issue, there are PPAs that have been updated with the code that fixes this issue. I'm using this while waiting for the official release: https://launchpad.net/~kisak/+archive/ubuntu/kisak-mesa?field.series_filter=jammy. Not the "correct" solution, I suppose, but it got me back up and running until the fix comes through.

[Oibaf (oibaf)]

Mantic now has 23.1.3 with the fix.