[ovn] N/S traffic for VMs without FIPs not working

[Luis Tomas]

The N/S traffic for VMs without FIPs is not working due to redirect-type=bridge option being set on cr-lrp for routers with geneve tenant networks connected to it. It seems this flag should only be used for vlan networks, and not for geneve

This option was recently added as part of [1]

[1] https://review.opendev.org/c/openstack/neutron/+/875644

[Akihiro Motoki (amotoki)]

https://review.opendev.org/c/openstack/neutron/+/878450

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/878450
Committed: https://opendev.org/openstack/neutron/commit/0ec04dd638da8cc9f4d5ebb21a09ea5ccb05623c
Submitter: "Zuul (22348)"
Branch: master

commit 0ec04dd638da8cc9f4d5ebb21a09ea5ccb05623c
Author: Luis Tomas Bolivar <email address hidden>
Date: Thu Mar 23 16:45:18 2023 +0100

    Ensure redirect-type=bridged not used for geneve networks

    As part of [1] the redirect-type=bridged flag was enabled by default.
    However this have the side effect of also decentralizing N/S traffic
    for geneve tenant networks, breaking the VM connectivity on them when
    it must be centralized, i.e., when no FIPs are associated to the VMs.

    This patch differentiates and only enable that flag when the networks
    conected through that router gateway port are of VLAN/FLAT type.

    In addition, to avoid MTU issues for the VLAN networks if there are
    also geneve networks connected to the same router, we re-take the
    approach on [2] to ensure the traffic is centralized but not tunneled

    [1] https://review.opendev.org/c/openstack/neutron/+/875644
    [2] https://review.opendev.org/c/openstack/neutron/+/875676

    Closes-Bug: #2012712

    Change-Id: I25e5ee2cf8daee52221a640faa7ac09679742707

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/neutron/+/879295

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/neutron/+/879296

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/neutron/+/879297

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/neutron/+/879298

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/neutron/+/879299

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/879295
Committed: https://opendev.org/openstack/neutron/commit/da7b17993316aae5c9e9bc8af0140835381be7f0
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit da7b17993316aae5c9e9bc8af0140835381be7f0
Author: Luis Tomas Bolivar <email address hidden>
Date: Thu Mar 23 16:45:18 2023 +0100

    Ensure redirect-type=bridged not used for geneve networks

    As part of [1] the redirect-type=bridged flag was enabled by default.
    However this have the side effect of also decentralizing N/S traffic
    for geneve tenant networks, breaking the VM connectivity on them when
    it must be centralized, i.e., when no FIPs are associated to the VMs.

    This patch differentiates and only enable that flag when the networks
    conected through that router gateway port are of VLAN/FLAT type.

    In addition, to avoid MTU issues for the VLAN networks if there are
    also geneve networks connected to the same router, we re-take the
    approach on [2] to ensure the traffic is centralized but not tunneled

    [1] https://review.opendev.org/c/openstack/neutron/+/875644
    [2] https://review.opendev.org/c/openstack/neutron/+/875676

    Closes-Bug: #2012712

    Conflicts:
        neutron/tests/unit/plugins/ml2/drivers/ovn/mech_driver/ovsdb/test_maintenance.py

    Change-Id: I25e5ee2cf8daee52221a640faa7ac09679742707
    (cherry picked from commit 0ec04dd638da8cc9f4d5ebb21a09ea5ccb05623c)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/879296
Committed: https://opendev.org/openstack/neutron/commit/ec1a0e27dcacd3a7ad54d16099e89c5c06547db0
Submitter: "Zuul (22348)"
Branch: stable/zed

commit ec1a0e27dcacd3a7ad54d16099e89c5c06547db0
Author: Luis Tomas Bolivar <email address hidden>
Date: Thu Mar 23 16:45:18 2023 +0100

    Ensure redirect-type=bridged not used for geneve networks

    As part of [1] the redirect-type=bridged flag was enabled by default.
    However this have the side effect of also decentralizing N/S traffic
    for geneve tenant networks, breaking the VM connectivity on them when
    it must be centralized, i.e., when no FIPs are associated to the VMs.

    This patch differentiates and only enable that flag when the networks
    conected through that router gateway port are of VLAN/FLAT type.

    In addition, to avoid MTU issues for the VLAN networks if there are
    also geneve networks connected to the same router, we re-take the
    approach on [2] to ensure the traffic is centralized but not tunneled

    [1] https://review.opendev.org/c/openstack/neutron/+/875644
    [2] https://review.opendev.org/c/openstack/neutron/+/875676

    Closes-Bug: #2012712

    Conflicts:
        neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py
        neutron/tests/unit/plugins/ml2/drivers/ovn/mech_driver/ovsdb/test_maintenance.py

    Change-Id: I25e5ee2cf8daee52221a640faa7ac09679742707
    (cherry picked from commit 0ec04dd638da8cc9f4d5ebb21a09ea5ccb05623c)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/879297
Committed: https://opendev.org/openstack/neutron/commit/c246913b2f21b832989220bc7e7dac6442797040
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit c246913b2f21b832989220bc7e7dac6442797040
Author: Luis Tomas Bolivar <email address hidden>
Date: Thu Mar 23 16:45:18 2023 +0100

    Ensure redirect-type=bridged not used for geneve networks

    As part of [1] the redirect-type=bridged flag was enabled by default.
    However this have the side effect of also decentralizing N/S traffic
    for geneve tenant networks, breaking the VM connectivity on them when
    it must be centralized, i.e., when no FIPs are associated to the VMs.

    This patch differentiates and only enable that flag when the networks
    conected through that router gateway port are of VLAN/FLAT type.

    In addition, to avoid MTU issues for the VLAN networks if there are
    also geneve networks connected to the same router, we re-take the
    approach on [2] to ensure the traffic is centralized but not tunneled

    [1] https://review.opendev.org/c/openstack/neutron/+/875644
    [2] https://review.opendev.org/c/openstack/neutron/+/875676

    Closes-Bug: #2012712

    Conflicts:
        neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py
        neutron/tests/unit/plugins/ml2/drivers/ovn/mech_driver/ovsdb/test_maintenance.py

    Change-Id: I25e5ee2cf8daee52221a640faa7ac09679742707
    (cherry picked from commit 0ec04dd638da8cc9f4d5ebb21a09ea5ccb05623c)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/879298
Committed: https://opendev.org/openstack/neutron/commit/dc2762edfc33ca1c5b5d84d0a7f0133d6021cf32
Submitter: "Zuul (22348)"
Branch: stable/xena

commit dc2762edfc33ca1c5b5d84d0a7f0133d6021cf32
Author: Luis Tomas Bolivar <email address hidden>
Date: Thu Mar 23 16:45:18 2023 +0100

    Ensure redirect-type=bridged not used for geneve networks

    As part of [1] the redirect-type=bridged flag was enabled by default.
    However this have the side effect of also decentralizing N/S traffic
    for geneve tenant networks, breaking the VM connectivity on them when
    it must be centralized, i.e., when no FIPs are associated to the VMs.

    This patch differentiates and only enable that flag when the networks
    conected through that router gateway port are of VLAN/FLAT type.

    In addition, to avoid MTU issues for the VLAN networks if there are
    also geneve networks connected to the same router, we re-take the
    approach on [2] to ensure the traffic is centralized but not tunneled

    [1] https://review.opendev.org/c/openstack/neutron/+/875644
    [2] https://review.opendev.org/c/openstack/neutron/+/875676

    Closes-Bug: #2012712

    Conflicts:
        neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py

    Change-Id: I25e5ee2cf8daee52221a640faa7ac09679742707
    (cherry picked from commit 0ec04dd638da8cc9f4d5ebb21a09ea5ccb05623c)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/879299
Committed: https://opendev.org/openstack/neutron/commit/7630b5d295de7b1235198785af35ec6f35174842
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 7630b5d295de7b1235198785af35ec6f35174842
Author: Luis Tomas Bolivar <email address hidden>
Date: Thu Mar 23 16:45:18 2023 +0100

    Ensure redirect-type=bridged not used for geneve networks

    As part of [1] the redirect-type=bridged flag was enabled by default.
    However this have the side effect of also decentralizing N/S traffic
    for geneve tenant networks, breaking the VM connectivity on them when
    it must be centralized, i.e., when no FIPs are associated to the VMs.

    This patch differentiates and only enable that flag when the networks
    conected through that router gateway port are of VLAN/FLAT type.

    In addition, to avoid MTU issues for the VLAN networks if there are
    also geneve networks connected to the same router, we re-take the
    approach on [2] to ensure the traffic is centralized but not tunneled

    [1] https://review.opendev.org/c/openstack/neutron/+/875644
    [2] https://review.opendev.org/c/openstack/neutron/+/875676

    Closes-Bug: #2012712

    Conflicts:
        neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py

    Change-Id: I25e5ee2cf8daee52221a640faa7ac09679742707
    (cherry picked from commit 0ec04dd638da8cc9f4d5ebb21a09ea5ccb05623c)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 19.7.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 23.0.0.0b2 development milestone.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 22.0.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 21.1.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 20.3.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron wallaby-eom release.