[ovn-octavia-provider] Job pep8 failing due to bandit new lint rule

Bug #2011573 reported by Fernando Royo
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
High
Fernando Royo

Bug Description

Pep8 jobs are failing in master and stables branches after update bandit to 1.7.5. Basically it is doing a new lint rule checking timeout is specified in any request.

The rule B113 is marked as a warning but it making the job failing.

[1] https://github.com/PyCQA/bandit/commit/5ff73ff8ff956df7d63fde49c3bd671db8e821eb

Changed in neutron:
assignee: nobody → Fernando Royo (froyoredhat)
Changed in neutron:
status: New → In Progress
Changed in neutron:
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ovn-octavia-provider (master)

Reviewed: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/877357
Committed: https://opendev.org/openstack/ovn-octavia-provider/commit/1878eb4c21040ee34cde8a1aae6d1fb8993ae332
Submitter: "Zuul (22348)"
Branch: master

commit 1878eb4c21040ee34cde8a1aae6d1fb8993ae332
Author: Fernando Royo <email address hidden>
Date: Tue Mar 14 12:18:34 2023 +0100

    Fix broken pep8 jobs due to bandit 1.7.5 updated version

    With the latest version of bandit (1.7.5), a new lint rule has been
    introduced that checks the inclusion of the timeout parameter for
    every "requests" call [1].

    So B113 lint rule[2] needs to be skipped or code adapted, this patch
    add the timeout parameter to the put/get requests.

    [1] https://github.com/PyCQA/bandit/commit/5ff73ff8ff956df7d63fde49c3bd671db8e821eb
    [2] https://bandit.readthedocs.io/en/latest/plugins/b113_request_without_timeout.html

    Closes-bug: #2011573
    Change-Id: I341faedbf7e237eed176e0d3ed3586b8d2c2cbb8

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ovn-octavia-provider (stable/2023.1)

Fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/877462

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ovn-octavia-provider (stable/zed)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ovn-octavia-provider (stable/yoga)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ovn-octavia-provider (stable/xena)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ovn-octavia-provider (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/877466

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ovn-octavia-provider (stable/2023.1)

Reviewed: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/877462
Committed: https://opendev.org/openstack/ovn-octavia-provider/commit/68251e4b413fa8295a2de43d2f52bc8b96c92580
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit 68251e4b413fa8295a2de43d2f52bc8b96c92580
Author: Fernando Royo <email address hidden>
Date: Tue Mar 14 12:18:34 2023 +0100

    Fix broken pep8 jobs due to bandit 1.7.5 updated version

    With the latest version of bandit (1.7.5), a new lint rule has been
    introduced that checks the inclusion of the timeout parameter for
    every "requests" call [1].

    So B113 lint rule[2] needs to be skipped or code adapted, this patch
    add the timeout parameter to the put/get requests.

    [1] https://github.com/PyCQA/bandit/commit/5ff73ff8ff956df7d63fde49c3bd671db8e821eb
    [2] https://bandit.readthedocs.io/en/latest/plugins/b113_request_without_timeout.html

    Closes-bug: #2011573
    Change-Id: I341faedbf7e237eed176e0d3ed3586b8d2c2cbb8
    (cherry picked from commit 1878eb4c21040ee34cde8a1aae6d1fb8993ae332)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/ovn-octavia-provider 4.0.0.0rc2

This issue was fixed in the openstack/ovn-octavia-provider 4.0.0.0rc2 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ovn-octavia-provider (stable/xena)

Reviewed: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/877465
Committed: https://opendev.org/openstack/ovn-octavia-provider/commit/17532ec46730007aa1d099114b08f86df1db4d1a
Submitter: "Zuul (22348)"
Branch: stable/xena

commit 17532ec46730007aa1d099114b08f86df1db4d1a
Author: Fernando Royo <email address hidden>
Date: Tue Mar 14 12:18:34 2023 +0100

    Fix broken pep8 jobs due to bandit 1.7.5 updated version

    With the latest version of bandit (1.7.5), a new lint rule has been
    introduced that checks the inclusion of the timeout parameter for
    every "requests" call [1].

    So B113 lint rule[2] needs to be skipped or code adapted, this patch
    add the timeout parameter to the put/get requests.

    [1] https://github.com/PyCQA/bandit/commit/5ff73ff8ff956df7d63fde49c3bd671db8e821eb
    [2] https://bandit.readthedocs.io/en/latest/plugins/b113_request_without_timeout.html

    Closes-bug: #2011573
    Change-Id: I341faedbf7e237eed176e0d3ed3586b8d2c2cbb8
    (cherry picked from commit 1878eb4c21040ee34cde8a1aae6d1fb8993ae332)

tags: added: in-stable-xena
tags: added: in-stable-wallaby
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ovn-octavia-provider (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/877466
Committed: https://opendev.org/openstack/ovn-octavia-provider/commit/8d9be2c3a006abfdde08e85f94c2042f0235c6d8
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 8d9be2c3a006abfdde08e85f94c2042f0235c6d8
Author: Fernando Royo <email address hidden>
Date: Tue Mar 14 12:18:34 2023 +0100

    Fix broken pep8 jobs due to bandit 1.7.5 updated version

    With the latest version of bandit (1.7.5), a new lint rule has been
    introduced that checks the inclusion of the timeout parameter for
    every "requests" call [1].

    So B113 lint rule[2] needs to be skipped or code adapted, this patch
    add the timeout parameter to the put/get requests.

    [1] https://github.com/PyCQA/bandit/commit/5ff73ff8ff956df7d63fde49c3bd671db8e821eb
    [2] https://bandit.readthedocs.io/en/latest/plugins/b113_request_without_timeout.html

    Closes-bug: #2011573
    Change-Id: I341faedbf7e237eed176e0d3ed3586b8d2c2cbb8
    (cherry picked from commit 1878eb4c21040ee34cde8a1aae6d1fb8993ae332)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ovn-octavia-provider (stable/zed)

Reviewed: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/877463
Committed: https://opendev.org/openstack/ovn-octavia-provider/commit/75b84560c486cae96789b154e41123aed9dd5c6a
Submitter: "Zuul (22348)"
Branch: stable/zed

commit 75b84560c486cae96789b154e41123aed9dd5c6a
Author: Fernando Royo <email address hidden>
Date: Tue Mar 14 12:18:34 2023 +0100

    Fix broken pep8 jobs due to bandit 1.7.5 updated version

    With the latest version of bandit (1.7.5), a new lint rule has been
    introduced that checks the inclusion of the timeout parameter for
    every "requests" call [1].

    So B113 lint rule[2] needs to be skipped or code adapted, this patch
    add the timeout parameter to the put/get requests.

    [1] https://github.com/PyCQA/bandit/commit/5ff73ff8ff956df7d63fde49c3bd671db8e821eb
    [2] https://bandit.readthedocs.io/en/latest/plugins/b113_request_without_timeout.html

    Closes-bug: #2011573
    Change-Id: I341faedbf7e237eed176e0d3ed3586b8d2c2cbb8
    (cherry picked from commit 1878eb4c21040ee34cde8a1aae6d1fb8993ae332)

tags: added: in-stable-zed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ovn-octavia-provider (stable/yoga)

Reviewed: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/877464
Committed: https://opendev.org/openstack/ovn-octavia-provider/commit/730843bd66a7ebf8b67ae18f7bcc1434d33f4e13
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit 730843bd66a7ebf8b67ae18f7bcc1434d33f4e13
Author: Fernando Royo <email address hidden>
Date: Tue Mar 14 12:18:34 2023 +0100

    Fix broken pep8 jobs due to bandit 1.7.5 updated version

    With the latest version of bandit (1.7.5), a new lint rule has been
    introduced that checks the inclusion of the timeout parameter for
    every "requests" call [1].

    So B113 lint rule[2] needs to be skipped or code adapted, this patch
    add the timeout parameter to the put/get requests.

    [1] https://github.com/PyCQA/bandit/commit/5ff73ff8ff956df7d63fde49c3bd671db8e821eb
    [2] https://bandit.readthedocs.io/en/latest/plugins/b113_request_without_timeout.html

    Closes-bug: #2011573
    Change-Id: I341faedbf7e237eed176e0d3ed3586b8d2c2cbb8
    (cherry picked from commit 1878eb4c21040ee34cde8a1aae6d1fb8993ae332)

tags: added: in-stable-yoga
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/ovn-octavia-provider 1.3.1

This issue was fixed in the openstack/ovn-octavia-provider 1.3.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/ovn-octavia-provider 3.1.1

This issue was fixed in the openstack/ovn-octavia-provider 3.1.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/ovn-octavia-provider 2.1.1

This issue was fixed in the openstack/ovn-octavia-provider 2.1.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/ovn-octavia-provider 5.0.0.0rc1

This issue was fixed in the openstack/ovn-octavia-provider 5.0.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/ovn-octavia-provider wallaby-eom

This issue was fixed in the openstack/ovn-octavia-provider wallaby-eom release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.