[OVN] Method ``get_port_qos`` should always return 2 values

[Rodolfo Alonso]

The method ``neutron.agent.ovn.agent.ovsdb.get_port_qos`` should always return 2 values. This is not happening in the (very rare) case of not finding the port logical_switch_port. In this case [1] we are only returning one value (an empty dictionary).

[1]https://github.com/openstack/neutron/blob/50dc9dd24377ddb04bcb7fc9be362894b6ed1490/neutron/agent/ovn/agent/ovsdb.py#L165

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/876945

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/neutron/+/876947

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/876945
Committed: https://opendev.org/openstack/neutron/commit/bffa642b351f7fc3bb5cfb7a1bb2a3499c4b4506
Submitter: "Zuul (22348)"
Branch: master

commit bffa642b351f7fc3bb5cfb7a1bb2a3499c4b4506
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Wed Mar 8 09:08:33 2023 +0100

    [OVN] Method ``get_port_qos`` should always return 2 values

    The method ``neutron.agent.ovn.agent.ovsdb.get_port_qos`` should
    always return 2 values, even when the LSP is not present. This
    patch:
    * fixes the output, returning 2 values
    * catches the exception raised when the LSP is not present in the
      OVN NB database
    * returns the default max_kbps and min_kbps values (0, 0).

    Closes-Bug: #2009804
    Change-Id: I03ea78fcc5825e35c07dda1aa790769aa918dd8a

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/876947
Committed: https://opendev.org/openstack/neutron/commit/b79990c7a2d831fa44afeed9f468d3bfbc478dad
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit b79990c7a2d831fa44afeed9f468d3bfbc478dad
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Wed Mar 8 09:08:33 2023 +0100

    [OVN] Method ``get_port_qos`` should always return 2 values

    The method ``neutron.agent.ovn.agent.ovsdb.get_port_qos`` should
    always return 2 values, even when the LSP is not present. This
    patch:
    * fixes the output, returning 2 values
    * catches the exception raised when the LSP is not present in the
      OVN NB database
    * returns the default max_kbps and min_kbps values (0, 0).

    Closes-Bug: #2009804
    Change-Id: I03ea78fcc5825e35c07dda1aa790769aa918dd8a
    (cherry picked from commit bffa642b351f7fc3bb5cfb7a1bb2a3499c4b4506)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 22.0.0.0rc2 release candidate.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 23.0.0.0b2 development milestone.