[OVS] "permitted_ethertypes" should be validated and filtered during the OVS agent initialization

Bug #2009728 reported by Rodolfo Alonso
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Low
Rodolfo Alonso

Bug Description

"permitted_ethertypes" is a comma separated list of ethertypes to be permitted, in hexadecimal. That means all values should start with a "0x".

In case that any of these values does not start with "0x", any time the port rules are refreshed, a new warning message is printed (in both directions).

Instead of this, this bug proposed to parse the "permitted_ethertypes" list at the initialization of the OVS agent, print any possible value error just once and store the valid values.

tags: added: low-hanging-fruit
Changed in neutron:
importance: Undecided → Low
Changed in neutron:
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/876997

Changed in neutron:
status: Confirmed → In Progress
Changed in neutron:
assignee: nobody → Rodolfo Alonso (rodolfo-alonso-hernandez)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/876997
Committed: https://opendev.org/openstack/neutron/commit/5c98d9e8d1bc66b0e5010e7d9abbe61cfcc7bae5
Submitter: "Zuul (22348)"
Branch: master

commit 5c98d9e8d1bc66b0e5010e7d9abbe61cfcc7bae5
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Wed Mar 8 17:14:19 2023 +0100

    [OVS] Parse the "permitted_ethertypes" at the FW initialization

    Parse and validate the "permitted_ethertypes" configuration variable at
    the OVS firewall initialization. Any error in the configuration will be
    logged only once.

    Closes-Bug: #2009728
    Change-Id: Ib5439791d7bc0a8457bb10f887b1077fd6438619

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 23.0.0.0b2

This issue was fixed in the openstack/neutron 23.0.0.0b2 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.