[OVN] HW offload event "QoSMinimumBandwidthEvent" fails if the min-bw rule is removed

Bug #2009703 reported by Rodolfo Alonso
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
High
Rodolfo Alonso

Bug Description

When the logical switch port "qos_min_rate" option is removed (for example when the QoS policy is unset from the port), the LSP.options dictionary doesn't have the "qos_min_rate". That leads to the following error: https://paste.opendev.org/show/be29CRKNP03adrTUZ0WH/

Tags: ovn qos
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/876872

Changed in neutron:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/2023.1)

Fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/neutron/+/876806

Changed in neutron:
assignee: nobody → Rodolfo Alonso (rodolfo-alonso-hernandez)
tags: added: ovn qos
Changed in neutron:
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/876872
Committed: https://opendev.org/openstack/neutron/commit/b9567033fc23e9288bf555eff306145ac66f260a
Submitter: "Zuul (22348)"
Branch: master

commit b9567033fc23e9288bf555eff306145ac66f260a
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Tue Mar 7 23:31:33 2023 +0100

    [OVN] Use the BW values retrieved from ``get_port_qos``

    In ``QoSMinimumBandwidthEvent`` and ``QoSBandwidthLimitEvent``, the
    bandwidth value is provided by the method ``get_port_qos``. This method
    handles when the value to be retrieved is not present in the
    required register and returns 0.

    Closes-Bug: #2009703
    Change-Id: Idbb8f98eaa429601e2f16861eb01ad72c68cffa6

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/2023.1)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/876806
Committed: https://opendev.org/openstack/neutron/commit/bf12a5c7b5bd04427d6ab7cd5afa9b8a0f4ed3f4
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit bf12a5c7b5bd04427d6ab7cd5afa9b8a0f4ed3f4
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Tue Mar 7 23:31:33 2023 +0100

    [OVN] Use the BW values retrieved from ``get_port_qos``

    In ``QoSMinimumBandwidthEvent`` and ``QoSBandwidthLimitEvent``, the
    bandwidth value is provided by the method ``get_port_qos``. This method
    handles when the value to be retrieved is not present in the
    required register and returns 0.

    Closes-Bug: #2009703
    Change-Id: Idbb8f98eaa429601e2f16861eb01ad72c68cffa6
    (cherry picked from commit b9567033fc23e9288bf555eff306145ac66f260a)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 22.0.0.0rc2

This issue was fixed in the openstack/neutron 22.0.0.0rc2 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 23.0.0.0b2

This issue was fixed in the openstack/neutron 23.0.0.0b2 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.