Additional Item creation attributes

Bug #2008904 reported by Josh Stompro
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
NCIPServer
Fix Committed
Wishlist
Unassigned

Bug Description

To make the transition to NCIP accept item usage for us easier, I would like to try and create items that closely match our current ILL item templates.

Here are a couple commits that add in setting the item price, shelving location, circ modifier and circ item as fields based on settings in the oils_ncip.xml file.

https://gitlab.com/LARL/ncipserver/-/commit/a7a19d81f28f6f13fc91005e00f84630d3de4fae
https://gitlab.com/LARL/ncipserver/-/commit/8b489a482bc10b35822685902c0bf3417500fbe6

Once I have these fully tested and if they seem like reasonable additions, I'll move them over to a working branch.

Josh

Tags: pullrequest
Revision history for this message
Josh Stompro (u-launchpad-stompro-org) wrote :

Working NCIPServer branch at user/stompro/lp2008904-item-attributes

https://git.evergreen-ils.org/?p=working/NCIPServer.git;a=shortlog;h=refs/heads/user/stompro/lp2008904-item-attributes

I'm working on testing these now. I'll reply back when I've tested them out.
Josh

Revision history for this message
Josh Stompro (u-launchpad-stompro-org) wrote :

I tested this out and found a variable copy paste error, fixed that and tested again and it works for me. I force pushed the fix to the above branch.

Josh

tags: added: pullrequest
Changed in ncipserver:
status: New → Confirmed
importance: Undecided → Wishlist
Changed in ncipserver:
assignee: nobody → Jason Stephenson (jstephenson)
Revision history for this message
Jason Stephenson (jstephenson) wrote :

Thanks, again, Josh!

I cleaned up some whitespace and squashed it into 1 commit and pushed it to main.

The new feature works for me and doesn't have any issues with a system using a legacy configuration.

Changed in ncipserver:
status: Confirmed → Fix Committed
assignee: Jason Stephenson (jstephenson) → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.