python 2.7 no longer supported with str(x,y) syntax added in 1.1.0

[Bo Bleckel]

When 1.1.0 was released, there was no mention of dropping Python 2.7 support. Now I know that we should have dropped that long ago, and we mostly have, but as it turns out, one app that we still support makes use of the dkimpy library and still supports python 2.7. We noticed in our weekend build that the newest version of the library uses a syntax that isn't supported by Python 2.7:

Line 303, in validate_signature_fields

    str(sig[b'd'], 'ascii')

TypeError: str() takes at most 1 argument (2 given)

It is totally fine if the package no longer supports Python 2.7 (I personally think that is probably the right approach), but then the 1.0.x version would be pulled in as the latest 2.7 supported version. That would be fine by us. It is a problem, however, for a version to be released with python 2.7 incompatible syntax but still purport to support 2.7.

Just some clarity would be appreciated! Thanks!

[Scott Kitterman (kitterman)]

I agree it should be documented. I'll fix that in the next update. Thanks.

[Scott Kitterman (kitterman)]

Documentation is updated in git.