[ovn-octavia-provider] LB ip port mapping clean up on every member change

Bug #2007835 reported by Fernando Royo
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
Fernando Royo

Bug Description

From patch [1], the ip_port_mapping is updated just adding and deleting every member after any related operation over the LB-HM, this operation is done in two steps, a db_clear and a db_set. Taking into account that ovsdbapp has specific commands for add/del backends to the ip_port_mapping seems more appropiate use those methods.

[1] https://review.opendev.org/c/openstack/ovn-octavia-provider/+/873426/10/ovn_octavia_provider/helper.py#1219

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ovn-octavia-provider (master)
Changed in neutron:
status: New → In Progress
Changed in neutron:
assignee: nobody → Fernando Royo (froyoredhat)
Changed in neutron:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ovn-octavia-provider (master)

Reviewed: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/874384
Committed: https://opendev.org/openstack/ovn-octavia-provider/commit/e40e0d62ac089afd14c03102d80990e792211af3
Submitter: "Zuul (22348)"
Branch: master

commit e40e0d62ac089afd14c03102d80990e792211af3
Author: Fernando Royo <email address hidden>
Date: Mon Feb 20 11:43:10 2023 +0100

    Use ovsdbapp commands to add/del backends to ip_port_mappings

    LB ip_port_mapping is updated just adding and deleting every member
    after any related operation over the LB-HM, this operation was done
    in two steps, a db_clear and a db_set.

    This patch takes ovsdbapp specific commands for add/del backends to
    the ip_port_mapping in a more appropiate way, reducing any further
    operation from OVN DBs not related to the member added/deleted. Also
    taking care about the possibility of the same backend_ip could be
    pointed by other member, under a different HM.

    ovsdbapp bumps to 2.1.0 to be able to use those new functionalities [1]

    [1] https://github.com/openstack/ovsdbapp/commit/f3c5da5402ea2d1c129684a84c91dbc72556f14f

    Closes-Bug: 2007835
    Change-Id: I5705c490bcd36e7e2edcc62954a3ffa0ff645519

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ovn-octavia-provider (stable/2023.1)

Fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/880951

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ovn-octavia-provider (stable/zed)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ovn-octavia-provider (stable/yoga)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ovn-octavia-provider (stable/xena)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ovn-octavia-provider (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/880955

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ovn-octavia-provider (stable/yoga)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on ovn-octavia-provider (stable/yoga)

Change abandoned by "Fernando Royo <email address hidden>" on branch: stable/yoga
Review: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/881809
Reason: Duplicate changeId by error

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ovn-octavia-provider (stable/2023.1)

Reviewed: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/880951
Committed: https://opendev.org/openstack/ovn-octavia-provider/commit/67fa32f857903f34c22834c06a4d110a80b0d0d4
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit 67fa32f857903f34c22834c06a4d110a80b0d0d4
Author: Fernando Royo <email address hidden>
Date: Mon Feb 20 11:43:10 2023 +0100

    Use ovsdbapp commands to add/del backends to ip_port_mappings

    LB ip_port_mapping is updated just adding and deleting every member
    after any related operation over the LB-HM, this operation was done
    in two steps, a db_clear and a db_set.

    This patch takes ovsdbapp specific commands for add/del backends to
    the ip_port_mapping in a more appropiate way, reducing any further
    operation from OVN DBs not related to the member added/deleted. Also
    taking care about the possibility of the same backend_ip could be
    pointed by other member, under a different HM.

    Note: In order to not bump versions of libraries on stable branches,
    the new ovsdbapp methods [1] needed are added to the local impl_idl_ovn.

    [1] https://github.com/openstack/ovsdbapp/commit/f3c5da5402ea2d1c129684a84c91dbc72556f14f

    (manually cherry picked from commit e40e0d62ac089afd14c03102d80990e792211af3)

    Closes-Bug: 2007835
    Change-Id: I5705c490bcd36e7e2edcc62954a3ffa0ff645519
    (cherry picked from commit e40e0d62ac089afd14c03102d80990e792211af3)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ovn-octavia-provider (stable/zed)

Reviewed: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/880952
Committed: https://opendev.org/openstack/ovn-octavia-provider/commit/dfb5cc7fe91485a36f585eb9ec02a1fe27a63d8f
Submitter: "Zuul (22348)"
Branch: stable/zed

commit dfb5cc7fe91485a36f585eb9ec02a1fe27a63d8f
Author: Fernando Royo <email address hidden>
Date: Mon Feb 20 11:43:10 2023 +0100

    Use ovsdbapp commands to add/del backends to ip_port_mappings

    LB ip_port_mapping is updated just adding and deleting every member
    after any related operation over the LB-HM, this operation was done
    in two steps, a db_clear and a db_set.

    This patch takes ovsdbapp specific commands for add/del backends to
    the ip_port_mapping in a more appropiate way, reducing any further
    operation from OVN DBs not related to the member added/deleted. Also
    taking care about the possibility of the same backend_ip could be
    pointed by other member, under a different HM.

    Note: In order to not bump versions of libraries on stable branches,
    the new ovsdbapp methods [1] needed are added to the local impl_idl_ovn.

    [1] https://github.com/openstack/ovsdbapp/commit/f3c5da5402ea2d1c129684a84c91dbc72556f14f

    (manually cherry picked from commit e40e0d62ac089afd14c03102d80990e792211af3)

    Closes-Bug: 2007835
    Change-Id: I5705c490bcd36e7e2edcc62954a3ffa0ff645519
    (cherry picked from commit e40e0d62ac089afd14c03102d80990e792211af3)

tags: added: in-stable-zed
tags: added: in-stable-yoga
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ovn-octavia-provider (stable/yoga)

Reviewed: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/880953
Committed: https://opendev.org/openstack/ovn-octavia-provider/commit/07281975500c91e28acbbeca82dc3fd53ffc8dba
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit 07281975500c91e28acbbeca82dc3fd53ffc8dba
Author: Fernando Royo <email address hidden>
Date: Mon Feb 20 11:43:10 2023 +0100

    Use ovsdbapp commands to add/del backends to ip_port_mappings

    LB ip_port_mapping is updated just adding and deleting every member
    after any related operation over the LB-HM, this operation was done
    in two steps, a db_clear and a db_set.

    This patch takes ovsdbapp specific commands for add/del backends to
    the ip_port_mapping in a more appropiate way, reducing any further
    operation from OVN DBs not related to the member added/deleted. Also
    taking care about the possibility of the same backend_ip could be
    pointed by other member, under a different HM.

    Note: In order to not bump versions of libraries on stable branches,
    the new ovsdbapp methods [1] needed are added to the local impl_idl_ovn.

    [1] https://github.com/openstack/ovsdbapp/commit/f3c5da5402ea2d1c129684a84c91dbc72556f14f

    (manually cherry picked from commit e40e0d62ac089afd14c03102d80990e792211af3)

    Closes-Bug: 2007835
    Change-Id: I5705c490bcd36e7e2edcc62954a3ffa0ff645519
    (cherry picked from commit e40e0d62ac089afd14c03102d80990e792211af3)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ovn-octavia-provider (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/880955
Committed: https://opendev.org/openstack/ovn-octavia-provider/commit/ac141a74517092a74ba627c1e7484394b7c4cf87
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit ac141a74517092a74ba627c1e7484394b7c4cf87
Author: Fernando Royo <email address hidden>
Date: Mon Feb 20 11:43:10 2023 +0100

    Use ovsdbapp commands to add/del backends to ip_port_mappings

    LB ip_port_mapping is updated just adding and deleting every member
    after any related operation over the LB-HM, this operation was done
    in two steps, a db_clear and a db_set.

    This patch takes ovsdbapp specific commands for add/del backends to
    the ip_port_mapping in a more appropiate way, reducing any further
    operation from OVN DBs not related to the member added/deleted. Also
    taking care about the possibility of the same backend_ip could be
    pointed by other member, under a different HM.

    Note: In order to not bump versions of libraries on stable branches,
    the new ovsdbapp methods [1] needed are added to the local impl_idl_ovn.

    [1] https://github.com/openstack/ovsdbapp/commit/f3c5da5402ea2d1c129684a84c91dbc72556f14f

    Conflicts:
          ovn_octavia_provider/helper.py

    (manually cherry picked from commit e40e0d62ac089afd14c03102d80990e792211af3)

    Closes-Bug: 2007835
    Change-Id: I5705c490bcd36e7e2edcc62954a3ffa0ff645519
    (cherry picked from commit e40e0d62ac089afd14c03102d80990e792211af3)

tags: added: in-stable-wallaby
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ovn-octavia-provider (stable/xena)

Reviewed: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/880954
Committed: https://opendev.org/openstack/ovn-octavia-provider/commit/b99f38e618662bd835373e7dce2d547ccb7ccde4
Submitter: "Zuul (22348)"
Branch: stable/xena

commit b99f38e618662bd835373e7dce2d547ccb7ccde4
Author: Fernando Royo <email address hidden>
Date: Mon Feb 20 11:43:10 2023 +0100

    Use ovsdbapp commands to add/del backends to ip_port_mappings

    LB ip_port_mapping is updated just adding and deleting every member
    after any related operation over the LB-HM, this operation was done
    in two steps, a db_clear and a db_set.

    This patch takes ovsdbapp specific commands for add/del backends to
    the ip_port_mapping in a more appropiate way, reducing any further
    operation from OVN DBs not related to the member added/deleted. Also
    taking care about the possibility of the same backend_ip could be
    pointed by other member, under a different HM.

    Note: In order to not bump versions of libraries on stable branches,
    the new ovsdbapp methods [1] needed are added to the local impl_idl_ovn.

    [1] https://github.com/openstack/ovsdbapp/commit/f3c5da5402ea2d1c129684a84c91dbc72556f14f

    (manually cherry picked from commit e40e0d62ac089afd14c03102d80990e792211af3)

    Closes-Bug: 2007835
    Change-Id: I5705c490bcd36e7e2edcc62954a3ffa0ff645519
    (cherry picked from commit e40e0d62ac089afd14c03102d80990e792211af3)

tags: added: in-stable-xena
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/ovn-octavia-provider 4.0.1

This issue was fixed in the openstack/ovn-octavia-provider 4.0.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/ovn-octavia-provider 3.1.1

This issue was fixed in the openstack/ovn-octavia-provider 3.1.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/ovn-octavia-provider 2.1.1

This issue was fixed in the openstack/ovn-octavia-provider 2.1.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/ovn-octavia-provider 5.0.0.0rc1

This issue was fixed in the openstack/ovn-octavia-provider 5.0.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/ovn-octavia-provider wallaby-eom

This issue was fixed in the openstack/ovn-octavia-provider wallaby-eom release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/ovn-octavia-provider xena-eom

This issue was fixed in the openstack/ovn-octavia-provider xena-eom release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.