Masakari charm does not configure correctly rabbitmq with ssl

[Aymen Frikha]

Hello,

In a deployment where we have charm rabbitmq related to Vault charm for SSL (AMQPS):

- ['vault:certificates', 'rabbitmq-server:certificates']

When masakari charm is related to rabbitmq: masakari:amqp rabbitmq-server:amqp

the charm does not correctly configure the rabbitmq integration. In the masakari.conf file we only have that:

transport_url = rabbit://masakari:C8MbX6mXS8mdWNZbVVGYbPbbZGTP2HNBr36jJF3VmskkZSdHNKFY6GGwkLRT3yKJ@10.25.1.154:5671,masakari:C8MbX6mXS8mdWNZbVVGYbPbbZGTP2HNBr36jJF3VmskkZSdHNKFY6GGwkLRT3yKJ@10.25.1.86:5671,masakari:C8MbX6mXS8mdWNZbVVGYbPbbZGTP2HNBr36jJF3VmskkZSdHNKFY6GGwkLRT3yKJ@10.25.1.92:5671/masakari

And we are missing that part:
[oslo_messaging_rabbit]
ssl = True
ssl_ca_file = /etc/masakari/rabbit-client-ca.pem

And we end up having those lines in the masakari-engine.log file:

2023-02-16 10:07:05.959 41952 ERROR oslo.messaging._drivers.impl_rabbit [-] Connection failed: Server unexpectedly closed connection (retrying in 0 seconds): OSError: Server unexpectedly closed connection
2023-02-16 10:07:05.963 41952 ERROR oslo.messaging._drivers.impl_rabbit [-] Connection failed: Server unexpectedly closed connection (retrying in 0 seconds): OSError: Server unexpectedly closed connection
2023-02-16 10:07:05.967 41952 ERROR oslo.messaging._drivers.impl_rabbit [-] Connection failed: Server unexpectedly closed connection (retrying in 14.0 seconds): OSError: Server unexpectedly closed connection

I'm using :
Openstack: Wallaby/stable
Ubuntu: Focal

[Aymen Frikha (aym-frikha)]

subscribed ~field-critical

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/charm-masakari/+/874091

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/charm-masakari/+/874091
Committed: https://opendev.org/openstack/charm-masakari/commit/f4a8f7c4dfc5a5ef0244b095b7ea83d1e78e99d0
Submitter: "Zuul (22348)"
Branch: master

commit f4a8f7c4dfc5a5ef0244b095b7ea83d1e78e99d0
Author: James Page <email address hidden>
Date: Thu Feb 16 11:52:27 2023 +0000

    Add section-oslo-rabbitmq to templates

    Ensure the RabbitMQ oslo.messaging section is used in all templates;
    this configures SSL options when deployed in TLS secured configurations
    with RabbitMQ.

    Change-Id: I0821304b3f0e586e3a868e3c95294a688bae085a
    Closes-Bug: 2007567

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/charm-masakari/+/874432

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/charm-masakari/+/874433

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/charm-masakari/+/874434

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/charm-masakari/+/874435

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/charm-masakari/+/874436

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/charm-masakari/+/874437

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/charm-masakari/+/874432
Committed: https://opendev.org/openstack/charm-masakari/commit/3a560c49f453883de098c4b71a4528caa5dbfddc
Submitter: "Zuul (22348)"
Branch: stable/zed

commit 3a560c49f453883de098c4b71a4528caa5dbfddc
Author: James Page <email address hidden>
Date: Thu Feb 16 11:52:27 2023 +0000

    Add section-oslo-rabbitmq to templates

    Ensure the RabbitMQ oslo.messaging section is used in all templates;
    this configures SSL options when deployed in TLS secured configurations
    with RabbitMQ.

    Change-Id: I0821304b3f0e586e3a868e3c95294a688bae085a
    Closes-Bug: 2007567
    (cherry picked from commit f4a8f7c4dfc5a5ef0244b095b7ea83d1e78e99d0)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/charm-masakari/+/874433
Committed: https://opendev.org/openstack/charm-masakari/commit/5dd6f7f2c0db3bdecea4b11678df24dd6e5cc3b6
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit 5dd6f7f2c0db3bdecea4b11678df24dd6e5cc3b6
Author: James Page <email address hidden>
Date: Thu Feb 16 11:52:27 2023 +0000

    Add section-oslo-rabbitmq to templates

    Ensure the RabbitMQ oslo.messaging section is used in all templates;
    this configures SSL options when deployed in TLS secured configurations
    with RabbitMQ.

    Change-Id: I0821304b3f0e586e3a868e3c95294a688bae085a
    Closes-Bug: 2007567
    (cherry picked from commit f4a8f7c4dfc5a5ef0244b095b7ea83d1e78e99d0)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/charm-masakari/+/874434
Committed: https://opendev.org/openstack/charm-masakari/commit/144b0d04a4fb0b45f8ac6964538fc595e70cfe8a
Submitter: "Zuul (22348)"
Branch: stable/xena

commit 144b0d04a4fb0b45f8ac6964538fc595e70cfe8a
Author: James Page <email address hidden>
Date: Thu Feb 16 11:52:27 2023 +0000

    Add section-oslo-rabbitmq to templates

    Ensure the RabbitMQ oslo.messaging section is used in all templates;
    this configures SSL options when deployed in TLS secured configurations
    with RabbitMQ.

    Change-Id: I0821304b3f0e586e3a868e3c95294a688bae085a
    Closes-Bug: 2007567
    (cherry picked from commit f4a8f7c4dfc5a5ef0244b095b7ea83d1e78e99d0)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/charm-masakari/+/874435
Committed: https://opendev.org/openstack/charm-masakari/commit/5b0387c5f343488b1fcb3154ecf049d6c3f350bc
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 5b0387c5f343488b1fcb3154ecf049d6c3f350bc
Author: James Page <email address hidden>
Date: Thu Feb 16 11:52:27 2023 +0000

    Add section-oslo-rabbitmq to templates

    Ensure the RabbitMQ oslo.messaging section is used in all templates;
    this configures SSL options when deployed in TLS secured configurations
    with RabbitMQ.

    Change-Id: I0821304b3f0e586e3a868e3c95294a688bae085a
    Closes-Bug: 2007567
    (cherry picked from commit f4a8f7c4dfc5a5ef0244b095b7ea83d1e78e99d0)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/charm-masakari/+/874436
Committed: https://opendev.org/openstack/charm-masakari/commit/d0bbaa0be20daccde4873c4c7235a3ac04af611c
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit d0bbaa0be20daccde4873c4c7235a3ac04af611c
Author: James Page <email address hidden>
Date: Thu Feb 16 11:52:27 2023 +0000

    Add section-oslo-rabbitmq to templates

    Ensure the RabbitMQ oslo.messaging section is used in all templates;
    this configures SSL options when deployed in TLS secured configurations
    with RabbitMQ.

    Change-Id: I0821304b3f0e586e3a868e3c95294a688bae085a
    Closes-Bug: 2007567
    (cherry picked from commit f4a8f7c4dfc5a5ef0244b095b7ea83d1e78e99d0)

[Billy Olsen (billy-olsen)]

Added releases/series that were affected. This was fixed in the wallaby branch and is already available to users, which was what was used for field-critical so unsubscribing the field-critical team here.

[Jadon Naas (jadonn)]

The fix for Ussuri was merged successfully today. The review can be seen at https://review.opendev.org/c/openstack/charm-masakari/+/874437. This issue should be fixed for all the releases except Train as noted.