Subscription UT error in Zuul

[Ai Hamano]

The following error occurs in Zuul.
-----
ft1.2: tackerclient.tests.unit.osc.v1.test_vnflcm_subsc.TestListLccnSubscription.test_take_action_with_paginationtesttools.testresult.real._StringException: Traceback (most recent call last):
  File "/home/zuul/src/opendev.org/openstack/python-tackerclient/tackerclient/tests/unit/osc/v1/test_vnflcm_subsc.py", line 139, in test_take_action_with_pagination
    expected_data.append(vnflcm_subsc_fakes.get_subscription_data(
  File "/home/zuul/src/opendev.org/openstack/python-tackerclient/tackerclient/tests/unit/osc/v1/vnflcm_subsc_fakes.py", line 166, in get_subscription_data
    subscription.pop(item)
KeyError: 'filter'
-----

This is because one test data is used in multiple tests.
So it has to be modified to create test data for each test.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/python-tackerclient/+/873856

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/python-tackerclient/+/873856
Committed: https://opendev.org/openstack/python-tackerclient/commit/a41323dc1df66ebd86e96e65137f3c7e2363b7f4
Submitter: "Zuul (22348)"
Branch: master

commit a41323dc1df66ebd86e96e65137f3c7e2363b7f4
Author: Ai Hamano <email address hidden>
Date: Thu Feb 16 15:59:24 2023 +0900

    Fix list VNF/Subscription UT error

    This patch resolves the following error caused by using one data in
    multiple tests.
    -----
    ft1.2: tackerclient.tests.unit.osc.v1.test_vnflcm_subsc.
    TestListLccnSubscription.test_take_action_with_
    paginationtesttools.testresult.real._StringException:
     Traceback (most recent call last):
      File "/home/zuul/src/opendev.org/openstack/
    python-tackerclient/tackerclient/tests/unit/osc/v1
    /test_vnflcm_subsc.py", line 139, in test_take_action_with_
    pagination
        expected_data.append(vnflcm_subsc_fakes.get_subscription_
    data(
      File "/home/zuul/src/opendev.org/openstack
    /python-tackerclient/tackerclient/tests/unit/osc/v1
    /vnflcm_subsc_fakes.py", line 166, in get_subscription_data
        subscription.pop(item)
    KeyError: 'filter'
    -----

    Add test data for each test.
    (Three data are set for each test data so that the first, last, and
    other values can be checked.)
    And change not to modify test data directly in get method.

    Closes-Bug: #2007524
    Change-Id: Id3919fc638f6b858c115a3a7d7e4ca60036217d4

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-tackerclient 1.13.0 release.