[UT] "test_create_ndp_proxy_with_duplicated" fail

[Rodolfo Alonso]

Logs: https://ed80b810bea8807f20d5-7fb466319126c0ae420f0e283e1354c1.ssl.cf2.rackcdn.com/873619/1/check/openstack-tox-py39/fe30f88/testr_results.html

Error: https://paste.opendev.org/show/b1NJ60MNYab8AtEtVIaM/

[yatin (yatinkarel)]

Multiple Failures as per opensearch[1] in master and stable/zed(test exists since zed release) branch across all unit test jobs(mostly in arm64 jobs):-
openstack-tox-py38-arm64 45.2%
openstack-tox-py310-arm64 38.1%
openstack-tox-py39-arm64 4.8%
openstack-tox-cover 4.8%
openstack-tox-py38 2.4%
openstack-tox-py39 2.4%
openstack-tox-py310 2.4%

[1] https://opensearch.logs.openstack.org/_dashboards/app/discover/?security_tenant=global#/?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:now-30d,to:now))&_a=(columns:!(_source),filters:!(),index:'94869730-aea8-11ec-9e6a-83741af3fdcd',interval:auto,query:(language:kuery,query:'message:%22in%20test_create_ndp_proxy_with_duplicated%22'),sort:!())

[Rodolfo Alonso (rodolfo-alonso-hernandez)]

I've executed manually this test and is indeed testing that we can't create a duplicated NDPProxy. But the test is taking almost 3 minutes to finish: https://paste.opendev.org/show/bgcH8c9CCEJI4nHjhnFx/. I'm investigating how to reproduce the exception without the timeout.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/873739

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/neutron/+/873786

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/873739
Committed: https://opendev.org/openstack/neutron/commit/595c387efb19744e1c9547b79501e4bb8a94ea0d
Submitter: "Zuul (22348)"
Branch: master

commit 595c387efb19744e1c9547b79501e4bb8a94ea0d
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Tue Feb 14 04:40:15 2023 +0100

    [UT] Mock the retry decorator when creating duplicated NDPProxy

    The test ``test_create_ndp_proxy_with_duplicated`` was correctly testing
    the creation of a duplicated NDPProxy object. However it was taking
    around 3 minutes because the decorator ``oslo_db_api.wrap_db_retry``
    was retrying the object creation several times. This patch mocks the
    retry decorator; now the test takes around 6 seconds.

    Closes-Bug: #2007254
    Change-Id: I2fcad691df4a7ae112e1d55fefe662016430aa5b

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/873786
Committed: https://opendev.org/openstack/neutron/commit/0bbab95265b0a167b5c6308a35d7922783d9178e
Submitter: "Zuul (22348)"
Branch: stable/zed

commit 0bbab95265b0a167b5c6308a35d7922783d9178e
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Tue Feb 14 04:40:15 2023 +0100

    [UT] Mock the retry decorator when creating duplicated NDPProxy

    The test ``test_create_ndp_proxy_with_duplicated`` was correctly testing
    the creation of a duplicated NDPProxy object. However it was taking
    around 3 minutes because the decorator ``oslo_db_api.wrap_db_retry``
    was retrying the object creation several times. This patch mocks the
    retry decorator; now the test takes around 6 seconds.

    Closes-Bug: #2007254
    Change-Id: I2fcad691df4a7ae112e1d55fefe662016430aa5b

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 22.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 21.1.0 release.