Manila error message with "%s" instead of the actual error

Bug #2007060 reported by Felipe Rodrigues
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Shared File Systems Service (Manila)
Fix Released
High
Felipe Rodrigues

Bug Description

Some manila HTTP error messages do not contain the correct information string. It comes with the "%s".

Example:

==> Delete Share with Replicas

---> Expected error: Delete for share s1 failed: Share 07c8ce4c-e55a-47b2-8b72-cb611c5eb7eb has replicas. Remove the replicas before deleting the share. (HTTP 409)
---> Actual result: Delete for share s1 failed: %(err)s (HTTP 409)

==> Delete Share with wrong state (like, error_deleting)

---> Expected error: Delete for share s1 failed: Invalid share: Share status must be one of ('available', 'error', 'inactive'). (HTTP 403)
---> Actual error: Delete for share s1 failed: Invalid share: %(reason)s. (HTTP 403)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/manila/+/873087

Changed in manila:
status: New → In Progress
Changed in manila:
importance: Undecided → High
assignee: nobody → Felipe Rodrigues (felipefutty)
milestone: none → antelope-3
milestone: antelope-3 → antelope-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (master)

Reviewed: https://review.opendev.org/c/openstack/manila/+/873087
Committed: https://opendev.org/openstack/manila/commit/a65dffc0c7c6699d2e8ebbee7521913ff0c02917
Submitter: "Zuul (22348)"
Branch: master

commit a65dffc0c7c6699d2e8ebbee7521913ff0c02917
Author: Felipe Rodrigues <email address hidden>
Date: Sun Feb 12 23:49:00 2023 -0300

    Fix Manila API error message

    Some Manila error messages were wrongly returning the string marker
    "%s" instead of the string content. This patch fixes them.

    Closes-Bug: #2007060
    Change-Id: Ib68f71e19f2ec1190cc431f029d996193008d557

Changed in manila:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/manila 16.0.0.0rc1

This issue was fixed in the openstack/manila 16.0.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (stable/zed)

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/manila/+/880326

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to manila (stable/yoga)

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/manila/+/882303

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (stable/zed)

Reviewed: https://review.opendev.org/c/openstack/manila/+/880326
Committed: https://opendev.org/openstack/manila/commit/315fc6509ef0f0b645851c60d58fdec237a79810
Submitter: "Zuul (22348)"
Branch: stable/zed

commit 315fc6509ef0f0b645851c60d58fdec237a79810
Author: Felipe Rodrigues <email address hidden>
Date: Sun Feb 12 23:49:00 2023 -0300

    Fix Manila API error message

    Some Manila error messages were wrongly returning the string marker
    "%s" instead of the string content. This patch fixes them.

    Closes-Bug: #2007060
    Change-Id: Ib68f71e19f2ec1190cc431f029d996193008d557
    (cherry picked from commit a65dffc0c7c6699d2e8ebbee7521913ff0c02917)

tags: added: in-stable-zed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to manila (stable/yoga)

Reviewed: https://review.opendev.org/c/openstack/manila/+/882303
Committed: https://opendev.org/openstack/manila/commit/3ba4d99288a372e5d9f7cf9f108399af92041553
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit 3ba4d99288a372e5d9f7cf9f108399af92041553
Author: Felipe Rodrigues <email address hidden>
Date: Sun Feb 12 23:49:00 2023 -0300

    Fix Manila API error message

    Some Manila error messages were wrongly returning the string marker
    "%s" instead of the string content. This patch fixes them.

    Closes-Bug: #2007060
    Change-Id: Ib68f71e19f2ec1190cc431f029d996193008d557
    (cherry picked from commit a65dffc0c7c6699d2e8ebbee7521913ff0c02917)
    (cherry picked from commit 315fc6509ef0f0b645851c60d58fdec237a79810)

tags: added: in-stable-yoga
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/manila 14.1.1

This issue was fixed in the openstack/manila 14.1.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/manila 15.3.0

This issue was fixed in the openstack/manila 15.3.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.