[OVN] OVN trunk driver is not bumping the OVN LSP "external_ids:revision_number"

Bug #2006734 reported by Rodolfo Alonso
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
High
Rodolfo Alonso

Bug Description

The OVN trunk driver is not bumping the OVN LSP "external_ids:revision_number" after updating the Neutron DB register. The methods ``OVNTrunkHandler._set_binding_profile`` and ``OVNTrunkHandler._unset_binding_profile`` are called from ``_set_sub_ports`` and ``_unset_sub_ports`` respectively. These methods create a Neutron DB and a OVN DB transactions in the same with clause. Inside both transactions, the port register (Neutron DB and OVN DB) is modified. However, the OVN register revision_number is not bumped consequently. That forces the maintenance task to review the OVN register and force an update.

Changed in neutron:
assignee: nobody → Rodolfo Alonso (rodolfo-alonso-hernandez)
Changed in neutron:
importance: Undecided → High
tags: added: ovn trunk
Changed in neutron:
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/873296

Changed in neutron:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/zed)

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/neutron/+/873612

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/yoga)

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/neutron/+/873613

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/xena)

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/neutron/+/873614

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/neutron/+/873616

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/zed)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/873612
Committed: https://opendev.org/openstack/neutron/commit/e4a72796dff3bf26cd6b420d233385ca0f78c6bf
Submitter: "Zuul (22348)"
Branch: stable/zed

commit e4a72796dff3bf26cd6b420d233385ca0f78c6bf
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Thu Feb 9 16:36:14 2023 +0100

    [OVN] Bump the port revision number in trunk driver

    When the subport binding information is updated in the OVN trunk
    driver, the OVN revision number should be updated too, same as
    in other ``ovn_client`` method, for example.

    Closes-Bug: #2006734
    Change-Id: Icda34910ea7fe308814e0cc60999b465d3540b67
    (cherry picked from commit fce516e3461054716ff2d4623c240d3e006acbeb)

tags: added: in-stable-zed
tags: added: in-stable-yoga
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/yoga)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/873613
Committed: https://opendev.org/openstack/neutron/commit/ff9d2fc33b68041ae4b649bb9f276e146e4fccf2
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit ff9d2fc33b68041ae4b649bb9f276e146e4fccf2
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Thu Feb 9 16:36:14 2023 +0100

    [OVN] Bump the port revision number in trunk driver

    When the subport binding information is updated in the OVN trunk
    driver, the OVN revision number should be updated too, same as
    in other ``ovn_client`` method, for example.

    Closes-Bug: #2006734
    Change-Id: Icda34910ea7fe308814e0cc60999b465d3540b67
    (cherry picked from commit fce516e3461054716ff2d4623c240d3e006acbeb)

tags: added: in-stable-xena
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/xena)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/873614
Committed: https://opendev.org/openstack/neutron/commit/ccd9d47cba5af6ec18c5289893d57b965404392c
Submitter: "Zuul (22348)"
Branch: stable/xena

commit ccd9d47cba5af6ec18c5289893d57b965404392c
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Thu Feb 9 16:36:14 2023 +0100

    [OVN] Bump the port revision number in trunk driver

    When the subport binding information is updated in the OVN trunk
    driver, the OVN revision number should be updated too, same as
    in other ``ovn_client`` method, for example.

    Closes-Bug: #2006734
    Change-Id: Icda34910ea7fe308814e0cc60999b465d3540b67
    (cherry picked from commit fce516e3461054716ff2d4623c240d3e006acbeb)

tags: added: in-stable-wallaby
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/873616
Committed: https://opendev.org/openstack/neutron/commit/20b3406c51361085fa79f200c2595814a026bf1f
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 20b3406c51361085fa79f200c2595814a026bf1f
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Thu Feb 9 16:36:14 2023 +0100

    [OVN] Bump the port revision number in trunk driver

    When the subport binding information is updated in the OVN trunk
    driver, the OVN revision number should be updated too, same as
    in other ``ovn_client`` method, for example.

    Closes-Bug: #2006734
    Change-Id: Icda34910ea7fe308814e0cc60999b465d3540b67
    (cherry picked from commit fce516e3461054716ff2d4623c240d3e006acbeb)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/873296
Committed: https://opendev.org/openstack/neutron/commit/fce516e3461054716ff2d4623c240d3e006acbeb
Submitter: "Zuul (22348)"
Branch: master

commit fce516e3461054716ff2d4623c240d3e006acbeb
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Thu Feb 9 16:36:14 2023 +0100

    [OVN] Bump the port revision number in trunk driver

    When the subport binding information is updated in the OVN trunk
    driver, the OVN revision number should be updated too, same as
    in other ``ovn_client`` method, for example.

    Closes-Bug: #2006734
    Change-Id: Icda34910ea7fe308814e0cc60999b465d3540b67

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 22.0.0.0rc1

This issue was fixed in the openstack/neutron 22.0.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 19.6.0

This issue was fixed in the openstack/neutron 19.6.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 20.3.0

This issue was fixed in the openstack/neutron 20.3.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 21.1.0

This issue was fixed in the openstack/neutron 21.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron wallaby-eom

This issue was fixed in the openstack/neutron wallaby-eom release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.