Please update bundled synctex

Bug #2006446 reported by Florian Weimer
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
qpdfview
Fix Committed
Medium
Adam Reichold

Bug Description

Please include this commit in the bundled synctex sources:

commit 2897465154892a7737dcc90e4d6a00a1d1b3922c
Author: Germán Poo-Caamaño <email address hidden>
Date: Sat May 30 16:15:27 2020 -0400

    Fix implicit declaration of vasprintf

    Fix build when compiling with `-Werror=implicit-function-declaration`.

https://github.com/jlaurens/synctex/commit/2897465154892a7737dcc90e4d6a00a1d1b3922c

It is needed for C99 compatibility.

Related to:

  <https://fedoraproject.org/wiki/Changes/PortingToModernC>
  <https://fedoraproject.org/wiki/Toolchain/PortingToModernC>

Revision history for this message
Adam Reichold (adamreichold) wrote (last edit ):

Hello Florian,

thank you for taking the time to report this! While version 0.5.0 was just released, I will update the bundled sources for 0.5.1. Just two questions so that I do the right thing:

* I usually import those sources from the TeXLive Subversion repository. Is the linked commit specific to the GitHub fork or can I just import the latest code from TeXLive as usual?

* Since this is referencing the Fedora change: If present at build time, qpdfview should prefer to link against the system-provided SyncTeX and the vendored sources are considered a fallback for more exotic platforms which do not ship that library. Does using pkg-config not work for the Fedora package or does the package need an additional build-time dependency on the SyncTeX library? Ideally, the vendored should not be built on a modern Linux distribution like Fedora.

Regards,
Adam

Changed in qpdfview:
status: New → In Progress
importance: Undecided → Medium
assignee: nobody → Adam Reichold (adamreichold)
Changed in qpdfview:
milestone: none → 0.5.1
Revision history for this message
Florian Weimer (fweimer) wrote :

According to my notes, synctex was updated from Github in: https://tug.org/svn/texlive?view=revision&revision=65582

So the current Subversion sources should be good.

Regarding the Fedora build configuration, the package doesn't build-depend on pkgconfig(synctex). As expected, the package is able to builds against the system version. It may just be an oversight.

Revision history for this message
Adam Reichold (adamreichold) wrote :

Fix committed in trunk revision 2152.

Changed in qpdfview:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.