Debian Patching: Patchstate incorrect when there are no hosts

[Jessica Castelino]

Brief Description
-----------------
If there are no hosts, the patchstate is expected to be "n/a" since we can't be sure of the current patch state. However, only the first patch is set to "n/a" while the remaining patch's have a patchstate of "Available" (or whatever was previously reported for them).

The fix is fairly simple. We must move the return statement outside the for loop.
https://opendev.org/starlingx/update/src/branch/master/sw-patch/cgcs-patch/cgcs_patch/patch_controller.py#L784

Severity
--------
Minor

Steps to Reproduce
------------------
Fail the network such that no hosts are detected for patching.
Run sw-patch query

Expected Behavior
------------------
Patchstate for all patches should be "n/a"

Actual Behavior
----------------
Patchstate fpr the first patch is "n/a" and the rest show stale values.

Reproducibility
---------------
100% reproducible

System Configuration
--------------------
Multi-node system

Branch/Pull Time/Commit
-----------------------
6th Feb, 2023

Last Pass
---------
N/A

Timestamp/Logs
--------------
N/A

Test Activity
-------------
Developer Testing

Workaround
----------
N/A

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/update/+/872807

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/update/+/872807
Committed: https://opendev.org/starlingx/update/commit/09048aa032d449c5d1c207baed8a4916b8c96334
Submitter: "Zuul (22348)"
Branch: master

commit 09048aa032d449c5d1c207baed8a4916b8c96334
Author: Jessica Castelino <email address hidden>
Date: Mon Feb 6 22:53:37 2023 +0000

    Fix: Patchstate incorrect when there are no hosts

    If there are no hosts, the patchstate is expected to be
    "n/a" since we can't be sure of the current patch state.
    However, only the first patch's patchstate is set to "n/a"
    while the remaining patch's have a patchstate of "Available"
    (or whatever was previously reported for them). This commit
    fixes the issue.

    Test Plan:
    Tested with unit test case

    Closes-Bug: 2006398
    Signed-off-by: Jessica Castelino <email address hidden>
    Change-Id: I7f34d35f552a04d46e3f88af9548d2e74c241310