OVN databases containers are not updated during update

[Sofer Athlan-Guyot]

During update, the OVN database containers are not updated:

    osp17.0 -> 17.1 update
    [tripleo-admin@controller-1 ~]$ sudo podman ps | grep ovn
    503897e01169 undercloud-0.ctlplane.redhat.local:8787/rh-osbs/rhosp17-openstack-ovn-nb-db-server:17.0_20220908.1 kolla_start 3 weeks ago Up 24 hours ovn_cluster_north_db_server
    6723bdc08d43 undercloud-0.ctlplane.redhat.local:8787/rh-osbs/rhosp17-openstack-ovn-sb-db-server:17.0_20220908.1 kolla_start 3 weeks ago Up 24 hours ovn_cluster_south_db_server
    bf80025be019 undercloud-0.ctlplane.redhat.local:8787/rh-osbs/rhosp17-openstack-ovn-northd:17.0_20220908.1 kolla_start 3 weeks ago Up 24 hours (healthy) ovn_cluster_northd
    8afe1e0aa88f undercloud-0.ctlplane.redhat.local:8787/rh-osbs/rhosp17-openstack-nova-novncproxy:17.1_20230130.1 kolla_start 20 hours ago Up 20 hours (healthy) nova_vnc_proxy
    f5fccc07d2ee undercloud-0.ctlplane.redhat.local:8787/rh-osbs/rhosp17-openstack-ovn-controller:17.1_20230130.1 kolla_start 20 hours ago Up 20 hours (healthy) ovn_controller

Since wallaby, OVN databases are not under pacemaker control, and uses the cluster feature of the dbs.

The template is missing the bits that trigger the container update.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/872596

[Sofer Athlan-Guyot (sofer-athlan-guyot)]

Downstream bz tracked there https://bugzilla.redhat.com/show_bug.cgi?id=2166883

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/873602

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/877663

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Sofer Athlan-Guyot <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/872596
Reason: Master is abandoned.

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Mikolaj Ciecierski <email address hidden>" on branch: stable/zed
Review: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/877663
Reason: Abandoned, no longer maintained branch. Please take a look at wallaby change.

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Ronelle Landy <email address hidden>" on branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/873602

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/873602
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/4ff9272b85775fca203919f42e1012eb96f9ed3a
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 4ff9272b85775fca203919f42e1012eb96f9ed3a
Author: Sofer Athlan-Guyot <email address hidden>
Date: Thu Feb 2 20:24:37 2023 +0100

    Add update of OVN cluster container.

    Currently OVN cluster images are not updated during update.

    For container to be updated we rely on either:
    - explicit update tasks: like it's done for pacemaker for instance;
    - docker_config tasks: those triggered by common_deploy_steps_tasks;

    Here the ovn cluster is setup using ansible and no extra update tasks
    are present, which makes the update process to ignore change in the
    container image configuration.

    We add the necessary code block in the update tasks so that the
    cluster container are updated using anchor and alias to avoid
    repetition.

    Furthermore we move the generation of the new container definition (in
    /var/lib/tripleo-config/container-startup-config) earlier in the
    update process. Doing so enable the new image definition to be
    available during the update tasks.

    Closes-Bug: #2004575
    Change-Id: Ieeea6267b7c35a76f83a463a7247802cba99c4b5