[Secure RBAC] List QoS Policies filtered by tags is not possible with new RBAC policies

Bug #2004013 reported by Slawek Kaplonski
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
High
Slawek Kaplonski

Bug Description

Failed test neutron_tempest_plugin.api.admin.test_tag.TagFilterQosPolicyTestJSON.test_filter_qos_policy_tags

Traceback (most recent call last):
  File "/opt/stack/tempest/tempest/common/utils/__init__.py", line 89, in wrapper
    return func(*func_args, **func_kwargs)
  File "/opt/stack/tempest/.tox/tempest/lib/python3.8/site-packages/neutron_tempest_plugin/api/admin/test_tag.py", line 448, in test_filter_qos_policy_tags
    self._test_filter_tags()
  File "/opt/stack/tempest/.tox/tempest/lib/python3.8/site-packages/neutron_tempest_plugin/api/admin/test_tag.py", line 254, in _test_filter_tags
    self._assertEqualResources([0, 1, 2], res)
  File "/opt/stack/tempest/.tox/tempest/lib/python3.8/site-packages/neutron_tempest_plugin/api/admin/test_tag.py", line 248, in _assertEqualResources
    self.assertEqual(set(expected), set(actual))
  File "/opt/stack/tempest/.tox/tempest/lib/python3.8/site-packages/testtools/testcase.py", line 393, in assertEqual
    self.assertThat(observed, matcher, message)
  File "/opt/stack/tempest/.tox/tempest/lib/python3.8/site-packages/testtools/testcase.py", line 480, in assertThat
    raise mismatch_error
testtools.matchers._impl.MismatchError: !=:
reference = {'0e134a78-4550-41fd-b391-5bfee04e8b35',
 '9d3c9eaf-ea1c-4967-940e-399eafc6e915',
 'f70593a6-a790-42b1-8530-ff93f7080355'}
actual = set()

Changed in neutron:
assignee: nobody → Slawek Kaplonski (slaweq)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/872396

Changed in neutron:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/872396
Committed: https://opendev.org/openstack/neutron/commit/221cf9497fed414b01206ece6c6d41d0ec7d4088
Submitter: "Zuul (22348)"
Branch: master

commit 221cf9497fed414b01206ece6c6d41d0ec7d4088
Author: Slawek Kaplonski <email address hidden>
Date: Wed Feb 1 11:25:04 2023 +0100

    [Secure RBAC] Add shared_qos_policy rule

    For shared QoS policies we need to have additional rule which will allow
    to list shared policies for projects which aren't owners of the QoS
    policy.

    Closes-bug: #2004013
    Closes-bug: #2004014
    Change-Id: I593896ab087e3d916b10d7d5f6b22b501060b934

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/zed)

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/neutron/+/875605

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 22.0.0.0rc1

This issue was fixed in the openstack/neutron 22.0.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/zed)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/875605
Committed: https://opendev.org/openstack/neutron/commit/ec8e43f824c6fc123fd449a9404564efb43a540c
Submitter: "Zuul (22348)"
Branch: stable/zed

commit ec8e43f824c6fc123fd449a9404564efb43a540c
Author: Slawek Kaplonski <email address hidden>
Date: Wed Feb 1 11:25:04 2023 +0100

    [Secure RBAC] Add shared_qos_policy rule

    For shared QoS policies we need to have additional rule which will allow
    to list shared policies for projects which aren't owners of the QoS
    policy.

    Closes-bug: #2004013
    Closes-bug: #2004014
    Change-Id: I593896ab087e3d916b10d7d5f6b22b501060b934
    (cherry picked from commit 221cf9497fed414b01206ece6c6d41d0ec7d4088)

tags: added: in-stable-zed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 21.1.0

This issue was fixed in the openstack/neutron 21.1.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.