ovs: Bridges are not properly created if bridge_mappings is a flat string with multiple items

[Takashi Kajinami]

When we define multiple bridge mappings in a flat string, a ovs bridge is created wrongly.

For example if we have the following definition in the manifest

class { 'neutron::agents::ml2::ovs':
  bridge_mappings => 'default:br-ex,tenant:br-tenant',
  manage_bridge => true
}

The bridge named 'br-ex,tenant:br-tenant' is created.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/puppet-neutron/+/871077

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/puppet-neutron/+/871077
Committed: https://opendev.org/openstack/puppet-neutron/commit/05b043698f1fc7511e3087bea6a4dada515e54a9
Submitter: "Zuul (22348)"
Branch: master

commit 05b043698f1fc7511e3087bea6a4dada515e54a9
Author: Takashi Kajinami <email address hidden>
Date: Thu Jan 19 19:22:58 2023 +0900

    Fix wrong bridge name if bridge_mappings is commma-separated string

    This change ensures the value is properly translated to a list even
    if it's a flat string so that the bridge name is properly picked up.

    This also fixes a few wrong assertions done in unit tests.

    Closes-Bug: #2003324
    Change-Id: I3a784588435619418cfd51a1ceffd9fd0ecd5e63

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/puppet-neutron/+/871558

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/puppet-neutron/+/871558
Committed: https://opendev.org/openstack/puppet-neutron/commit/a2d49ef58e9a31fe6c5a99b8a2b7e63646ea2101
Submitter: "Zuul (22348)"
Branch: stable/zed

commit a2d49ef58e9a31fe6c5a99b8a2b7e63646ea2101
Author: Takashi Kajinami <email address hidden>
Date: Thu Jan 19 19:22:58 2023 +0900

    Fix wrong bridge name if bridge_mappings is commma-separated string

    This change ensures the value is properly translated to a list even
    if it's a flat string so that the bridge name is properly picked up.

    This also fixes a few wrong assertions done in unit tests.

    Closes-Bug: #2003324
    Change-Id: I3a784588435619418cfd51a1ceffd9fd0ecd5e63
    (cherry picked from commit 05b043698f1fc7511e3087bea6a4dada515e54a9)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/puppet-neutron/+/872290

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/puppet-neutron/+/872290
Committed: https://opendev.org/openstack/puppet-neutron/commit/9540933d918d498b4e1c1d55dc2ae63ac88a948b
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit 9540933d918d498b4e1c1d55dc2ae63ac88a948b
Author: Takashi Kajinami <email address hidden>
Date: Thu Jan 19 19:22:58 2023 +0900

    Fix wrong bridge name if bridge_mappings is commma-separated string

    This change ensures the value is properly translated to a list even
    if it's a flat string so that the bridge name is properly picked up.

    This also fixes a few wrong assertions done in unit tests.

    Closes-Bug: #2003324
    Change-Id: I3a784588435619418cfd51a1ceffd9fd0ecd5e63
    (cherry picked from commit 05b043698f1fc7511e3087bea6a4dada515e54a9)
    (cherry picked from commit a2d49ef58e9a31fe6c5a99b8a2b7e63646ea2101)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/puppet-neutron/+/872812

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/puppet-neutron/+/872812
Committed: https://opendev.org/openstack/puppet-neutron/commit/4a41c221fcec82dc25b099a94180eb65734efa0e
Submitter: "Zuul (22348)"
Branch: stable/xena

commit 4a41c221fcec82dc25b099a94180eb65734efa0e
Author: Takashi Kajinami <email address hidden>
Date: Thu Jan 19 19:22:58 2023 +0900

    Fix wrong bridge name if bridge_mappings is commma-separated string

    This change ensures the value is properly translated to a list even
    if it's a flat string so that the bridge name is properly picked up.

    This also fixes a few wrong assertions done in unit tests.

    Closes-Bug: #2003324
    Change-Id: I3a784588435619418cfd51a1ceffd9fd0ecd5e63
    (cherry picked from commit 05b043698f1fc7511e3087bea6a4dada515e54a9)
    (cherry picked from commit a2d49ef58e9a31fe6c5a99b8a2b7e63646ea2101)
    (cherry picked from commit 9540933d918d498b4e1c1d55dc2ae63ac88a948b)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-neutron 22.0.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-neutron 19.5.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-neutron 20.4.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-neutron 21.0.1 release.