Launchpad itself

support https scheme for branch.composePublicURL

Bug #2002569 reported by Jelmer Vernooij
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Triaged
Low
Unassigned

Bug Description

branch.composePublicURL doesn't support "https" as a scheme, just "http". Hopefully it should be trivial to also support the former. :)

See original description
Tags: api lp-code

Related branches

~jelmer/launchpad:public-https
Launchpad code reviewers: Pending requested
Diff: 76 lines (+9/-10)
4 files modified
lib/lp/code/interfaces/branch.py (+2/-2)
lib/lp/code/interfaces/codehosting.py (+1/-1)
lib/lp/code/model/branch.py (+2/-2)
lib/lp/code/tests/test_branch.py (+4/-5)
Guruprasad (lgp171188)
tags: added: api lp-code
Changed in launchpad:
status: New → Triaged
importance: Undecided → Low
Revision history for this message
Jürgen Gmach (jugmac00) wrote :

> branch.composePublicURL doesn't support "https" as a scheme, just "https".

Could you please elaborate? I do not get it.

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

Sorry, apparently my fingers have trouble typing "http" rather than "https" these days. I meant that only "http" is supported, not "https"

description: updated
Colin Watson (cjwatson)
description: updated
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.