Update to 3.0.16+dfsg-1ubuntu3.2 on 18.04 creates default and inner-tunnel in sites-enabled, breaking the currently installed setup

[CvB]

The summary pretty much says it all:

Updating freeradius packages on Ubuntu 18.04.6 to 3.0.16+dfsg-1ubuntu3.2 of the freeradius packages creates links in /etc/freeradius/3.0/sites-enabled for default and inner-tunnel.

These config links are added in addition to any config already existing there from the previously working installation, thereby
- possibly creating error messages about missing modules which prevent freeradius from starting, and
- preventing the configured site from starting by blocking ports for the default installation (once missing modules for the added default sites have been installed by the admin)

[Alan DeKok (aland-freeradius)]

This happens when you rename all of the virtual servers to something completely different. It's the default behavior of the normal installation.

[CvB (cvb-kruemel)]

For an installation, I understand. I was surprised to see this as a consequence of "apt upgrade" of a working installation.

[Sergio Durigan Junior (sergiodj)]

Thanks for taking the time to report a bug.

The code responsible for creating the default/inner-tunnel symlinks comes from debian/freeradius{,-config}.postinst, and looks like this:

27 # Create links for default sites, but only if this is an initial
28 # install or an upgrade from before there were links; users may
29 # want to remove them...
30 if [ -z "$2" ] || dpkg --compare-versions "$2" lt 2.0.4+dfsg-4; then
31 for site in default inner-tunnel; do
32 if test ! -h /etc/freeradius/3.0/sites-enabled/$site && \
33 test ! -e /etc/freeradius/3.0/sites-enabled/$site; then
34 ln -s ../sites-available/$site /etc/freeradius/3.0/sites-enabled/$site
35 fi
36 done
37 fi

This is correct, and does what the comment above it explains: it only creates the symlinks if (a) you're doing an initial install, or (b) you're upgrading from version 2.0.4+dfsg-4.

I was not able to reproduce the bug you mentioned, so I would like to ask if you could:

- Provide the steps necessary to reproduce it.

- Provide logs from "apt upgrade", if you still have them.

For now, I am marking this bug as Incomplete. Feel free to set it back to New once you've provided the information requested above.

Thanks.

[CvB (cvb-kruemel)]

(Possibly) even better: I do have a VM saved in the pre-update state, i.e. in the state in which the update "breaks" the setup here.

I run:
apt-get update
apt-get -y dist-upgrade

Screen output from the update:

Hit:1 http://packages.azlux.fr/debian buster InRelease
Hit:2 http://de.archive.ubuntu.com/ubuntu bionic InRelease
Hit:3 http://security.ubuntu.com/ubuntu bionic-security InRelease
Hit:4 http://de.archive.ubuntu.com/ubuntu bionic-updates InRelease
Hit:5 http://de.archive.ubuntu.com/ubuntu bionic-backports InRelease
Get:6 https://dl.ubnt.com/unifi/debian stable InRelease [3,038 B]
Reading package lists... Done
E: Repository 'https://dl.ubnt.com/unifi/debian stable InRelease' changed its 'Codename' value from 'unifi-6.4' to 'unifi-7.3'
N: This must be accepted explicitly before updates for this repository can be applied. See apt-secure(8) manpage for details.
Reading package lists... Done
Building dependency tree
Reading state information... Done
Calculating upgrade... Done
The following NEW packages will be installed:
  linux-headers-4.15.0-202 linux-headers-4.15.0-202-generic
  linux-image-4.15.0-202-generic linux-modules-4.15.0-202-generic
  linux-modules-extra-4.15.0-202-generic
The following packages will be upgraded:
  curl freeradius freeradius-common freeradius-config freeradius-utils
  libasn1-8-heimdal libcurl3-gnutls libcurl4 libfreeradius3 libgssapi3-heimdal
  libhcrypto4-heimdal libheimbase1-heimdal libheimntlm0-heimdal
  libhx509-5-heimdal libkrb5-26-heimdal libksba8 libroken18-heimdal
  libwind0-heimdal linux-generic linux-headers-generic linux-image-generic
  open-vm-tools python-apt-common python3-apt vim vim-common vim-runtime
  vim-tiny xxd
29 upgraded, 5 newly installed, 0 to remove and 0 not upgraded.
Need to get 78.0 MB of archives.
After this operation, 350 MB of additional disk space will be used.
Get:1 http://de.archive.ubuntu.com/ubuntu bionic-updates/main amd64 vim amd64 2:8.0.1453-1ubuntu1.10 [1,153 kB]
Get:2 http://de.archive.ubuntu.com/ubuntu bionic-updates/main amd64 vim-tiny amd64 2:8.0.1453-1ubuntu1.10 [477 kB]
Get:3 http://de.archive.ubuntu.com/ubuntu bionic-updates/main amd64 vim-runtime all 2:8.0.1453-1ubuntu1.10 [5,439 kB]
Get:4 http://de.archive.ubuntu.com/ubuntu bionic-updates/main amd64 xxd amd64 2:8.0.1453-1ubuntu1.10 [49.9 kB]
Get:5 http://de.archive.ubuntu.com/ubuntu bionic-updates/main amd64 vim-common all 2:8.0.1453-1ubuntu1.10 [71.0 kB]
Get:6 http://de.archive.ubuntu.com/ubuntu bionic-updates/main amd64 python-apt-common all 1.6.6 [16.9 kB]
Get:7 http://de.archive.ubuntu.com/ubuntu bionic-updates/main amd64 python3-apt amd64 1.6.6 [149 kB]
Get:8 http://de.archive.ubuntu.com/ubuntu bionic-updates/main amd64 curl amd64 7.58.0-2ubuntu3.22 [159 kB]
Get:9 http://de.archive.ubuntu.com/ubuntu bionic-updates/main amd64 libcurl4 amd64 7.58.0-2ubuntu3.22 [220 kB]
Get:10 http://de.archive.ubuntu.com/ubuntu bionic-updates/main amd64 freeradius-common all 3.0.16+dfsg-1ubuntu3.2 [214 kB]
Get:11 http://de.archive.ubuntu.com/ubuntu bionic-updates/main amd64 freeradius-config amd64 3.0.16+dfsg-1ubuntu3.2 [150 kB]
Get:12 http://de.archive.ubuntu.com/ubuntu bionic-updates/main amd64 freeradius-utils amd64 3...

[Robie Basak (racb)]

Sorry, it looks like we (I, in our process, ie. my fault) missed your reply. Unfortunately 18.04 is now beyond its End of Standard Support, but this issue might still affect Expanded Security Maintenance so it would be useful to understand it.

It's great that you have the saved VM. I hope you still have it!

We need steps to reproduce please, which you would need to derive from your saved VM state. What steps could a developer follow to install and configure freeradius using the previous package version, and then upgrade, to reproduce the issue? Figuring out the exact steps is necessary in order to understand what caused the problem, which is necessary to prevent a recurrence.

[Launchpad Janitor (janitor)]

[Expired for freeradius (Ubuntu) because there has been no activity for 60 days.]