add_circle_outline and remove_circle_outline on catalog search results screen need aria-labels

Bug #2002363 reported by Jane Sandberg
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Low
Unassigned
3.9
Fix Released
Low
Unassigned

Bug Description

Expected behavior:
The "plus" and "minus" buttons provide a meaningful accessible name to screen readers.

Actual behavior:
When I tab to these buttons on VoiceOver, it reads the material icons ligatures, "add_circle_outline" and "remove_circle_outline"

Steps to reproduce (without a screen reader):
* In Firefox, do a search in the staff catalog
* Right-click on the plus button near your search query
* Note that in the name column, the pushbutton's name is "add_circle_outline"

To fix this, the material-icons <span>s need aria-labels that override the ligature with something more useful to users.

Revision history for this message
Stephanie Leary (stephanieleary) wrote :

Branch: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sleary/lp2002363-aria-label-search-row-buttons

I've used the same phrases from the title attributes on the parent buttons, to allow dictation users to use those tooltips to identify the phrases they should speak to select these buttons.

To test, use the accessibility tab on your browser inspector and look for the accessible name property on the <span>s containing the icons.

Changed in evergreen:
status: New → Confirmed
milestone: none → 3.11-beta
tags: added: pullrequest
Changed in evergreen:
assignee: nobody → Chrystal Messam (badger85)
Revision history for this message
Chrystal Messam (badger85) wrote :

Screen narrator says "add underscore circle underscore outline button"

Changed in evergreen:
assignee: Chrystal Messam (badger85) → nobody
description: updated
Revision history for this message
Stephanie Leary (stephanieleary) wrote :

Thanks, Chrystal! I realized that I put the aria-label on the span (where it's not supported) instead of the button (where it belongs). I've fixed it and updated the branch.

Revision history for this message
Chrystal Messam (badger85) wrote :

I have tested this code and consent to signing off on it with my name, Chrystal Messam and my email address, <email address hidden>.

Changed in evergreen:
assignee: nobody → Chrystal Messam (badger85)
tags: added: signedoff
Changed in evergreen:
assignee: Chrystal Messam (badger85) → nobody
Revision history for this message
Galen Charlton (gmc) wrote :

Pushed down to rel_3_9. Thanks, Stephanie and Chrystal!

Changed in evergreen:
importance: Undecided → Low
assignee: nobody → Galen Charlton (gmc)
milestone: 3.11-beta → 3.10.2
status: Confirmed → Fix Committed
assignee: Galen Charlton (gmc) → nobody
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.