New version of shellcheck (0.9.0) causing failures in unrelated changes
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
StarlingX |
Fix Released
|
Critical
|
Unassigned |
Bug Description
Brief Description
-----------------
Review submissions now blowing up in unrelated code areas:
In /home/zuul/
local SAVEDLOGS=
^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In /home/zuul/
if [ ! -f ${SAVEDLOGS} ]; then
^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In /home/zuul/
tar czf ${SAVEDLOGS} ${LOGDIR} 2>/dev/null
^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In /home/zuul/
chmod 600 ${SAVEDLOGS}
In /home/zuul/
if [ -d ${FILEBUCKET_PATH} ]; then
^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In /home/zuul/
rm -fr ${FILEBUCKET_
Severity
--------
Provide the severity of the defect.
<Critical: System/Feature is not usable due to the defect>
<Major: System/Feature is usable but degraded>
<Minor: System/Feature is usable with minor issue>
Steps to Reproduce
------------------
Submit a review and observe new noise
Expected Behavior
------------------
Expecting code that wasn't changes and previously passed checks to no be flagged
Actual Behavior
----------------
Infrastructure uprev now flags new errors
Reproducibility
---------------
100%
System Configuration
-------
N/A
Branch/Pull Time/Commit
-------
master
Last Pass
---------
N/A
Timestamp/Logs
--------------
N/A
Test Activity
-------------
Code submission
Fix proposed to branch: master /review. opendev. org/c/starlingx /stx-puppet/ +/868059
Review: https:/