Attribute error in neutron-ovs-agent

[Slawek Kaplonski]

I noticed in the Openvswitch agent logs in the CI jobs stacktraces like:

Dec 12 09:44:51.014564 nested-virt-ubuntu-jammy-ovh-bhs1-0032473968 neutron-openvswitch-agent[57685]: ERROR neutron.agent.rpc [None req-024660c2-8e49-4135-8322-2ea29fac319e None None] Failed to get details for device d9cdde27-90fa-425f-a42c-f8464806457f: AttributeError: 'NoneType' object has no attribute 'qos_policy_id'
Dec 12 09:44:51.014564 nested-virt-ubuntu-jammy-ovh-bhs1-0032473968 neutron-openvswitch-agent[57685]: ERROR neutron.agent.rpc Traceback (most recent call last):
Dec 12 09:44:51.014564 nested-virt-ubuntu-jammy-ovh-bhs1-0032473968 neutron-openvswitch-agent[57685]: ERROR neutron.agent.rpc File "/opt/stack/neutron/neutron/agent/rpc.py", line 321, in get_devices_details_list_and_failed_devices
Dec 12 09:44:51.014564 nested-virt-ubuntu-jammy-ovh-bhs1-0032473968 neutron-openvswitch-agent[57685]: ERROR neutron.agent.rpc self.get_device_details(context, device, agent_id, host,
Dec 12 09:44:51.014564 nested-virt-ubuntu-jammy-ovh-bhs1-0032473968 neutron-openvswitch-agent[57685]: ERROR neutron.agent.rpc File "/opt/stack/neutron/neutron/agent/rpc.py", line 355, in get_device_details
Dec 12 09:44:51.014564 nested-virt-ubuntu-jammy-ovh-bhs1-0032473968 neutron-openvswitch-agent[57685]: ERROR neutron.agent.rpc qos_network_policy_id = net.qos_policy_id
Dec 12 09:44:51.014564 nested-virt-ubuntu-jammy-ovh-bhs1-0032473968 neutron-openvswitch-agent[57685]: ERROR neutron.agent.rpc AttributeError: 'NoneType' object has no attribute 'qos_policy_id'
Dec 12 09:44:51.014564 nested-virt-ubuntu-jammy-ovh-bhs1-0032473968 neutron-openvswitch-agent[57685]: ERROR neutron.agent.rpc

Example of such error: https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_d8f/860270/8/check/neutron-tempest-plugin-openvswitch/d8f61ec/controller/logs/screen-q-agt.txt

It don't cause job failure but should be handled in better way in the code to avoid ugly stacktraces.

[Lajos Katona (lajos-katona)]

Search link with OpenSearch:
https://opensearch.logs.openstack.org/_dashboards/app/discover/?security_tenant=global#/?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:now-30d,to:now))&_a=(columns:!(build_name,build_status),filters:!(),index:'94869730-aea8-11ec-9e6a-83741af3fdcd',interval:auto,query:(language:kuery,query:'message:%22AttributeError:%20!'NoneType!'%20object%20has%20no%20attribute%20!'qos_policy_id!'%22'),sort:!())

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/869678

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/869678
Committed: https://opendev.org/openstack/neutron/commit/2495ad285614d3a77d3387a0913e1d82f4f8f61b
Submitter: "Zuul (22348)"
Branch: master

commit 2495ad285614d3a77d3387a0913e1d82f4f8f61b
Author: elajkat <email address hidden>
Date: Tue Jan 10 11:54:57 2023 +0100

    Avoid failure of get_device_details if net from cache is empty

    CacheBackedPluginApi.get_device_details tries to fetch net info
    from remote_resource_cache to fill the qos_policy_id for the
    device.
    Fix the case when the cache has no entry for the network.

    Change-Id: I1612dc4515ec0f02fbaf05d60b753485885d8c84
    Closes-bug: #1999391

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 22.0.0.0rc1 release candidate.