prepare-upload pushes unnecessarily when sponsoring
Bug #1999177 reported by
Robie Basak
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
git-ubuntu |
Fix Released
|
Wishlist
|
Robie Basak |
Bug Description
When sponsoring an upload, it'd be nice to be able to point to the sponsoree branch instead of making the sponsor push to their own. prepare-upload could do this by fetching/updating the remote ref and checking that the HEAD commit is reachable from it. If it is not, then fall back to the push-to-own-remote behaviour; otherwise use the remote.
Related branches
~racb/git-ubuntu:prepare-upload-fetch
- Server Team CI bot: Approve (continuous-integration)
- Steve Langasek: Approve
- git-ubuntu developers: Pending requested
-
Diff: 1106 lines (+709/-141)3 files modifiedgitubuntu/prepare_upload.py (+401/-91)
gitubuntu/prepare_upload_test.py (+299/-43)
sandbox/gu-build (+9/-7)
Changed in git-ubuntu: | |
status: | Triaged → In Progress |
assignee: | nobody → Robie Basak (racb) |
To post a comment you must log in.
The --branch and --remote options would still be needed to detect which remote ref to use. So it'd be push-to-that-remote if the remote branch isn't up-to-date.