Taskflow doesn't treat boolean configuration properly

[Dmitriy Rabotyagov]

At the moment taskflow just tries to load the configuration with getting attribute from passed config and assuming it's boolean:
https://opendev.org/openstack/taskflow/src/commit/5bcac4c7d4503be8161bcf159981199e3ea89d4d/taskflow/jobs/backends/impl_zookeeper.py#L832

In fact, at least octavia does pass variables as str and not as bool.

So in case in octavia.conf you will define following:

[task_flow]
jobboard_zookeeper_ssl_options = use_ssl:True,verify_certs:False,check_compatible:False

taskflow will end up with wrong behaviour. Since type(self._conf['check_compatible']) is str, condition `if self._conf.get('check_compatible', True)` will be treated as true no matter value you place, as non-empty string will always be evaluated as True.

While with use_ssl it's not _that_ critical as default value is False, so to disable you can simply skip defining the variable, for verify_certs and check_compatible things are way worse.

[Gregory Thiemonge (gthiemonge)]

Yes, the config values have to be sanitized (the redis backend already converts the values to booleans), I can work on it.

[Gregory Thiemonge (gthiemonge)]

I proposed a fix at https://review.opendev.org/c/openstack/taskflow/+/867083

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/taskflow/+/867083
Committed: https://opendev.org/openstack/taskflow/commit/086b3e4335194cbe2bbfcd8c422fa21952124b44
Submitter: "Zuul (22348)"
Branch: master

commit 086b3e4335194cbe2bbfcd8c422fa21952124b44
Author: Gregory Thiemonge <email address hidden>
Date: Fri Dec 9 02:14:36 2022 -0500

    Fix parsing of zookeeper jobboard backend options

    Fix the zookeeper backend options when values are passed as strings,
    a "False" string is now treated as the False boolean.

    Closes-Bug: #1999174
    Change-Id: I048faf06d89ebf980efe0598e647f2ec89f65ada

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/2023.1
Review: https://review.opendev.org/c/openstack/taskflow/+/880605

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/taskflow 5.2.0 release.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/taskflow/+/880605
Committed: https://opendev.org/openstack/taskflow/commit/78aa34f45930d3a3389bcf55becf6d84aac8ae51
Submitter: "Zuul (22348)"
Branch: stable/2023.1

commit 78aa34f45930d3a3389bcf55becf6d84aac8ae51
Author: Gregory Thiemonge <email address hidden>
Date: Fri Dec 9 02:14:36 2022 -0500

    Fix parsing of zookeeper jobboard backend options

    Fix the zookeeper backend options when values are passed as strings,
    a "False" string is now treated as the False boolean.

    Closes-Bug: #1999174
    Change-Id: I048faf06d89ebf980efe0598e647f2ec89f65ada
    (cherry picked from commit 086b3e4335194cbe2bbfcd8c422fa21952124b44)