dcmanager subcloud backup creates multiple directories under one release
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
StarlingX |
Fix Released
|
Low
|
André Dexheimer Carneiro |
Bug Description
------- Brief Description
There is no semantic check to prevent backup operation when there is already a backup create operation in progress. When you create subcloud backup for group 2 times in a row, it ends up creating a new release directory under the existing release directory, also it ends up creating 2 new backup files.
------- Severity
Minor: Doesnt affect the functionality but the existing file is not deleted
------- Steps to Reproduce
1. Execute backup create when the backup create already in progress using --group option
------- Expected Behavior
The second backup create option is either ignored or stopped using a semantic check.
------- Actual Behavior
Backup directory structures are not created as per requirement. Unwanted files are left after the backup operation
------- Reproducibility
Reproducible
------- System Configuration
DC System
Changed in starlingx: | |
status: | New → In Progress |
Changed in starlingx: | |
assignee: | nobody → André Dexheimer Carneiro (andre-dexheimercarneiro) |
Changed in starlingx: | |
importance: | Undecided → Low |
tags: | added: stx.8.0 stx.distcloud |
Reviewed: https:/ /review. opendev. org/c/starlingx /distcloud/ +/865853 /opendev. org/starlingx/ distcloud/ commit/ fe50d060c8fe282 af3079fadca7ad8 0c232a2ea2
Committed: https:/
Submitter: "Zuul (22348)"
Branch: master
commit fe50d060c8fe282 af3079fadca7ad8 0c232a2ea2
Author: Andre Carneiro <email address hidden>
Date: Mon Nov 28 11:20:36 2022 -0300
Add check to prevent concurrent backup operations
This commit adds semantic check to avoid concurrent backup and
restore operations on the same subcloud. This check is used twice:
- By the API, to return an error if all the subclouds, specified using
either --subcloud or --group options, have an ongoing backup and
restore operation.
- By the backend, to filter out any subclouds where backup and
restore operations are in progress so that concurrent
operations aren't triggered.
Test Plan:
1. PASS - Validate that concurrent backup create operations can't be
triggered on a subcloud using the --subcloud option.
2. PASS - Validate that the API returns an error if all the subclouds
specified have an ongoing backup create operation.
3. PASS - Validate that concurrent backup operations aren't started on
any subclouds when using the --group option.
4. PASS - Validate that concurrent backup restore operations can't be
triggered on a subcloud using the --subcloud option.
5. PASS - Validate that the API returns an error if all the subclouds
specified have an ongoing backup restore operation.
6. PASS - Validate that concurrent backup restore operations aren't
started on any subclouds when using the --group option.
Closes-Bug: 1998500
Signed-off-by: Andre Carneiro <email address hidden> 400070cc41131b8 1dc5e3ddd56
Change-Id: Ic11de20d7a323c