Missing Local Installer title in Local Install Grub menu

[Shrikumar Sharma]

DC Debian: Missing Local Installer title in Grub menu for subcloud local install

Actual result:

Booting from Disk connected to front USB 1: DataTraveler 3.0
Welcome to GRUB!error: no such device: ((cd0,msdos2)/EFI/BOOT)/EFI/BOOT/grub.cfg.
                         GNU GRUB version 2.06-1.stx.5
/-----------------------------------------------------------------\
 | Serial Console |
 |*Graphical Console |
 | |
 | |
 \----------------------------------------------------------------/
script (gen-prestaged-iso.sh):
menuentry 'Serial Console' --id=serial {
    linux /bzImage-std ${COMMON_ARGS} traits=controller console=ttyS0,115200 serial
    initrd /initrd
}menuentry 'Graphical Console' --id=graphical {
    linux /bzImage-std ${COMMON_ARGS} traits=controller console=tty0
    initrd /initrd
}
Expected Result: (what we have in gen-prestaged-iso.sh script for CentOS)

Graphical console output when the subcloud is booting from USB: Loading Lifecycle Controller Drivers...
Loading Lifecycle Controller Drivers...Done
Lifecycle Controller: Collecting System Inventory...

 Prestaged Local Installer
 Serial Console
 Graphical Console
 script:
menu begin
    menu title ${MENU_NAME}
   # Serial Console submenu
    label 0
        menu label Serial Console
        kernel vmlinuz
        initrd initrd.img
        append rootwait ${COMMON_ARGS} console=ttyS0,115200 serial
    # Graphical Console submenu
    label 1
        menu label Graphical Console
        kernel vmlinuz
        initrd initrd.img
        append rootwait ${COMMON_ARGS} console=tty0
menu end

Severity

<Minor: System/Feature is usable with minor issue>

Steps to Reproduce

Generate prestaged.iso

Burn prestaged.iso into a USB

Boot subcloud from USB

Expected Behavior

The grub menu should indicate that the subcloud is booting from a local installation option.

Actual Behavior

Grub menu does not indicate which kind of installation the server/subcloud in running

Reproducibility

100% reproducible

System Configuration

DC

Load info (eg: 2022-03-10_20-00-07)

[sysadmin@controller-0 prestage-files(keystone_admin)]$ cat /etc/build.info
SW_VERSION="22.12"
BUILD_TARGET="Host Installer"
BUILD_TYPE="Formal"
BUILD_ID="2022-11-11_18-00-09"
SRC_BUILD_ID="222"JOB="wrcp-master-debian"
BUILD_BY="jenkins"
BUILD_NUMBER="159"
BUILD_HOST="yow-wrcp-lx.wrs.com"
BUILD_DATE="2022-11-11 23:00:09 +0000"
Last Pass

new test scenario.

Timestamp/Logs

n/a

Alarms

n/a

Test Activity

Feature Testing

Workaround

n/a

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/utilities/+/865608
Committed: https://opendev.org/starlingx/utilities/commit/0a9923e377dcfaf279e5ce243f1d1ef5b447f001
Submitter: "Zuul (22348)"
Branch: master

commit 0a9923e377dcfaf279e5ce243f1d1ef5b447f001
Author: ssharma3 <email address hidden>
Date: Thu Nov 24 23:40:11 2022 +0000

    Missing Local Installer title in Local Install Grub menu

    This commit provides a title in the grub menu for local
    installation. It indicates the purpose of the installer.

    Test Plan:
    PASS: Verify that an appropriate title is present in the grub
          menu.

    Closes-Bug: 1997917

    Change-Id: Id1fb8cfe27a2fd2ce74c385076134d2a4b716e1b
    Signed-off-by: ssharma3 <email address hidden>