swift::storage::node fails if storage_local_net_ip is IPv6 address

[Takashi Kajinami]

The swift::storage::node class consistently fails if storage_local_net_ip is set to an IPv6 address.
The failure is caused by the address not properly formatted in URI.
~~~
Parameter name failed on Ring_object_device[0:0000:0000:0000:0000:0000:0000:0000:0001:6020/2]: Validate method failed for class name: bad URI(is not URI?): "http://0000:0000:0000:0000:0000:0000:0000:0001:6020/2" (file: /home/zuul/workspace/spec/fixtures/modules/swift/manifests/storage/node.pp, line: 81)
~~~

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/puppet-swift/+/865215
Committed: https://opendev.org/openstack/puppet-swift/commit/a8ef5f69060adda86433ff2de4c761a0f86f68c3
Submitter: "Zuul (22348)"
Branch: master

commit a8ef5f69060adda86433ff2de4c761a0f86f68c3
Author: Takashi Kajinami <email address hidden>
Date: Tue Nov 22 11:13:16 2022 +0900

    Format IPv6 address for ring device

    The IPv6 addresses in ring_*_device resource names should be surrounded
    by []. This ensures the address is properly formatted when the resource
    is define in swift::storage::node.

    Closes-Bug: #1997295
    Change-Id: I390f3c7bbfbbbc7217f81e8a0312e5db201ef409

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/puppet-swift/+/865568

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/puppet-swift/+/865568
Committed: https://opendev.org/openstack/puppet-swift/commit/7af17ae2540a0d778d15a85d5f72dcfb5ed2c233
Submitter: "Zuul (22348)"
Branch: stable/zed

commit 7af17ae2540a0d778d15a85d5f72dcfb5ed2c233
Author: Takashi Kajinami <email address hidden>
Date: Tue Nov 22 11:13:16 2022 +0900

    Format IPv6 address for ring device

    The IPv6 addresses in ring_*_device resource names should be surrounded
    by []. This ensures the address is properly formatted when the resource
    is define in swift::storage::node.

    Closes-Bug: #1997295
    Change-Id: I390f3c7bbfbbbc7217f81e8a0312e5db201ef409
    (cherry picked from commit a8ef5f69060adda86433ff2de4c761a0f86f68c3)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/puppet-swift/+/866003

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/puppet-swift/+/866003
Committed: https://opendev.org/openstack/puppet-swift/commit/d7bd7ce916e195f39e1daee5b456cdacd8c19af7
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit d7bd7ce916e195f39e1daee5b456cdacd8c19af7
Author: Takashi Kajinami <email address hidden>
Date: Tue Nov 22 11:13:16 2022 +0900

    Format IPv6 address for ring device

    The IPv6 addresses in ring_*_device resource names should be surrounded
    by []. This ensures the address is properly formatted when the resource
    is define in swift::storage::node.

    Closes-Bug: #1997295
    Change-Id: I390f3c7bbfbbbc7217f81e8a0312e5db201ef409
    (cherry picked from commit a8ef5f69060adda86433ff2de4c761a0f86f68c3)
    (cherry picked from commit 7af17ae2540a0d778d15a85d5f72dcfb5ed2c233)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-swift 22.0.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-swift 20.4.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-swift 21.0.1 release.