Bootstrap Opac: Inconsistent behavior in bib email form

[Garry Collum]

I'm breaking this off from Eva's comment in lp1955079 pertaining to inconsistent behavior in the opac's form to mail bibliographic data to patrons.

"Inconsistent behavior of Update button in relation to individual field of the form:
- When changing most values (Email address, Subject, Sorting, etc.), it is necessary to click the button "Update" i to save the submitted value.
- When values in the Format field are changed, it is not necessary to update the form - full or brief format are applied to the email sent just by changing the value in the form."

Also while looking at this, I discovered that by default the Subject content is hard-coded in the trigger. No matter what is input, or not input into the subject field, the result is "Bibliographic Records."

The page could also benefit from a bit of styling to make it more consistent with other pages in the opac.

[Garry Collum (gcollum)]

A proposed patch is at https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gcollum/lp195510_Bootstrap_opac_email_form

It's best to test after Jane's patch for LP1955079 is applied, but not necessary.

It does the following:

All of the drop-down lists will now refresh the page so that the preview is updated.

The email field requires a value and must be in an email format. The update button is next to this field and is only enabled when there is a change in the field.

The subject field has been hidden with a 'Fixme' tag. Currently the subject is always 'Bibliographic Records' regardless of what is entered in the field.

The style has been changed to be more consistent with other pages in the opac.

[Susan Morrison (smorrison425)]

Confirmed all inputs refreshed the page and preview, and that Update Preview updated the email address as expected. Only comment is that there are some minor alignment and spacing inconsistencies in the form. Also, 'Return' looks a tad off-center vertically within the button, but that may just be my bad eyes. Attached a screenshot.

[Jennifer Pringle (jpringle-u)]

I see the alignment issues too. The fields and labels for Email Address and Format are indented further than the fields and labels for Sort By and Sort Order.

According to the ruler that I put on my screen the word Return is slightly higher than the words Email Now.

[Garry Collum (gcollum)]

I removed the pullrequest on this. It appears a link with a button class in Bootstrap and button tag in Bootstrap display slightly different.