MAAS cannot mark "broken" VMs as fixed without recommissioning

Bug #1994899 reported by Bill Wear
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
MAAS
Fix Released
Medium
Igor Brovtsin

Bug Description

On MAAS 3.2.6 (at least), VMs marked as "Broken" cannot be marked as "Fixed". This is because of the following code in `src/maasserver/node_action.py:785`:

```python
            script_failures = script_set.scriptresult_set.exclude(
                status=SCRIPT_STATUS.PASSED
            )
```

Since VMs skip `30-maas-01-bmc-config` -- because they don't actually authenticate thru a BMC -- it's impossible with the above code in place to ever come back from "Broken" without recommissioning the VM.

Note that https://code.launchpad.net/~igor-brovtsin/maas/+git/maas/+merge/431630 addresses this particular situation, but it's uncertain if there are other cases where a SKIP might not warrant a commissioning failure status, so filing the bug anyway.

Related branches

Revision history for this message
Bill Wear (billwear) wrote :

for example, src/metadataserver/models/scriptresult.py:164 is another case where adding SKIPPED might be necessary.

Changed in maas:
importance: Undecided → Medium
milestone: none → 3.3.0
status: New → In Progress
assignee: nobody → Igor Brovtsin (igor-brovtsin)
Changed in maas:
status: In Progress → Fix Committed
Changed in maas:
milestone: 3.3.0 → 3.3.0-beta3
Changed in maas:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.