Disable in-band flow management in the ovs bridges

[Slawek Kaplonski]

Currently when restarting neutron, neutron do following setup

a) set controller 127.0.0.1
b) set out-of-band mode

between a) and b), ovs runs with in-band mode and it has hidden flow in bridge. The hidden flow causing odd dataplane flow.

To avoid that potensial odd dataplane flow we should do one of below:
a) configure the controller and set it to out-of-band in a single db transaction, i.e. "ovs-vsctl set-controller br-tenant tcp:127.0.0.1:6633 -- set controller br-tenant connection-mode=out-of-band" or
b) configure disable-in-band to true for the bridge before configuring the controller, i.e. “ovs-vsctl set bridge br-tenant other-config:disable-in-band=true”

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/861351

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/861351
Committed: https://opendev.org/openstack/neutron/commit/8fcf00a36dfcec80bba73b63896d806f48835faf
Submitter: "Zuul (22348)"
Branch: master

commit 8fcf00a36dfcec80bba73b63896d806f48835faf
Author: Slawek Kaplonski <email address hidden>
Date: Fri Oct 14 11:58:02 2022 +0200

    Disable in-band management for bridges before setting up controllers

    Disabling in-band management for bridge will effectively disable it for
    all controllers which are or will be set for the bridge. This will
    prevent us from having short time between configuring controller and
    setting connection_mode of the controller to "out-of-band" when
    controller works in the default "in-band" connection mode and adds some
    hidden flows to the bridge.

    Closes-Bug: #1992953
    Change-Id: Ibca81eb59fbfad71f223832228f408fb248c5dfa

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/neutron/+/861622

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/neutron/+/861623

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/neutron/+/861624

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/neutron/+/861625

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/neutron/+/861705

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/neutron/+/861706

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/c/openstack/neutron/+/861707

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/c/openstack/neutron/+/861708

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/c/openstack/neutron/+/861626

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.opendev.org/c/openstack/neutron/+/861627

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/861622
Committed: https://opendev.org/openstack/neutron/commit/b304dfaca791d3396fc0c6210cb1b1b089970a0f
Submitter: "Zuul (22348)"
Branch: stable/zed

commit b304dfaca791d3396fc0c6210cb1b1b089970a0f
Author: Slawek Kaplonski <email address hidden>
Date: Fri Oct 14 11:58:02 2022 +0200

    Disable in-band management for bridges before setting up controllers

    Disabling in-band management for bridge will effectively disable it for
    all controllers which are or will be set for the bridge. This will
    prevent us from having short time between configuring controller and
    setting connection_mode of the controller to "out-of-band" when
    controller works in the default "in-band" connection mode and adds some
    hidden flows to the bridge.

    Closes-Bug: #1992953
    Change-Id: Ibca81eb59fbfad71f223832228f408fb248c5dfa
    (cherry picked from commit 8fcf00a36dfcec80bba73b63896d806f48835faf)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/861625
Committed: https://opendev.org/openstack/neutron/commit/9d826bc77aab36dd194cc471397af68bd4ad39e5
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 9d826bc77aab36dd194cc471397af68bd4ad39e5
Author: Slawek Kaplonski <email address hidden>
Date: Fri Oct 14 11:58:02 2022 +0200

    Disable in-band management for bridges before setting up controllers

    Disabling in-band management for bridge will effectively disable it for
    all controllers which are or will be set for the bridge. This will
    prevent us from having short time between configuring controller and
    setting connection_mode of the controller to "out-of-band" when
    controller works in the default "in-band" connection mode and adds some
    hidden flows to the bridge.

    Closes-Bug: #1992953
    Change-Id: Ibca81eb59fbfad71f223832228f408fb248c5dfa
    (cherry picked from commit 8fcf00a36dfcec80bba73b63896d806f48835faf)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/861705
Committed: https://opendev.org/openstack/neutron/commit/32a8b2d3388b0e1ed4b19a5f3b68a99762f9f70b
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit 32a8b2d3388b0e1ed4b19a5f3b68a99762f9f70b
Author: Slawek Kaplonski <email address hidden>
Date: Fri Oct 14 11:58:02 2022 +0200

    Disable in-band management for bridges before setting up controllers

    Disabling in-band management for bridge will effectively disable it for
    all controllers which are or will be set for the bridge. This will
    prevent us from having short time between configuring controller and
    setting connection_mode of the controller to "out-of-band" when
    controller works in the default "in-band" connection mode and adds some
    hidden flows to the bridge.

    Conflicts:
        neutron/plugins/ml2/drivers/openvswitch/agent/openflow/native/ovs_bridge.py
        neutron/tests/unit/plugins/ml2/drivers/openvswitch/agent/openflow/native/ovs_bridge_test_base.py

    Closes-Bug: #1992953
    Change-Id: Ibca81eb59fbfad71f223832228f408fb248c5dfa
    (cherry picked from commit 8fcf00a36dfcec80bba73b63896d806f48835faf)
    (cherry picked from commit 9d826bc77aab36dd194cc471397af68bd4ad39e5)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/861706
Committed: https://opendev.org/openstack/neutron/commit/b662fd25773647259f0e8c197beafa6a5ca385d4
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit b662fd25773647259f0e8c197beafa6a5ca385d4
Author: Slawek Kaplonski <email address hidden>
Date: Fri Oct 14 11:58:02 2022 +0200

    Disable in-band management for bridges before setting up controllers

    Disabling in-band management for bridge will effectively disable it for
    all controllers which are or will be set for the bridge. This will
    prevent us from having short time between configuring controller and
    setting connection_mode of the controller to "out-of-band" when
    controller works in the default "in-band" connection mode and adds some
    hidden flows to the bridge.

    Conflicts:
        neutron/plugins/ml2/drivers/openvswitch/agent/openflow/native/ovs_bridge.py
        neutron/tests/functional/agent/test_ovs_lib.py
        neutron/tests/unit/plugins/ml2/drivers/openvswitch/agent/openflow/native/ovs_bridge_test_base.py

    Closes-Bug: #1992953
    Change-Id: Ibca81eb59fbfad71f223832228f408fb248c5dfa
    (cherry picked from commit 8fcf00a36dfcec80bba73b63896d806f48835faf)
    (cherry picked from commit 9d826bc77aab36dd194cc471397af68bd4ad39e5)
    (cherry picked from commit 32a8b2d3388b0e1ed4b19a5f3b68a99762f9f70b)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/861624
Committed: https://opendev.org/openstack/neutron/commit/5dac0105c217d2ae6d882e1dd29f10c50bab6998
Submitter: "Zuul (22348)"
Branch: stable/xena

commit 5dac0105c217d2ae6d882e1dd29f10c50bab6998
Author: Slawek Kaplonski <email address hidden>
Date: Fri Oct 14 11:58:02 2022 +0200

    Disable in-band management for bridges before setting up controllers

    Disabling in-band management for bridge will effectively disable it for
    all controllers which are or will be set for the bridge. This will
    prevent us from having short time between configuring controller and
    setting connection_mode of the controller to "out-of-band" when
    controller works in the default "in-band" connection mode and adds some
    hidden flows to the bridge.

    Closes-Bug: #1992953
    Change-Id: Ibca81eb59fbfad71f223832228f408fb248c5dfa
    (cherry picked from commit 8fcf00a36dfcec80bba73b63896d806f48835faf)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/861707
Committed: https://opendev.org/openstack/neutron/commit/d163bf7e4a1ca34eb9cbcd7ee408026fb4aca127
Submitter: "Zuul (22348)"
Branch: stable/train

commit d163bf7e4a1ca34eb9cbcd7ee408026fb4aca127
Author: Slawek Kaplonski <email address hidden>
Date: Fri Oct 14 11:58:02 2022 +0200

    Disable in-band management for bridges before setting up controllers

    Disabling in-band management for bridge will effectively disable it for
    all controllers which are or will be set for the bridge. This will
    prevent us from having short time between configuring controller and
    setting connection_mode of the controller to "out-of-band" when
    controller works in the default "in-band" connection mode and adds some
    hidden flows to the bridge.

    Conflicts:
        neutron/plugins/ml2/drivers/openvswitch/agent/openflow/native/ovs_bridge.py
        neutron/tests/functional/agent/test_ovs_lib.py
        neutron/tests/unit/plugins/ml2/drivers/openvswitch/agent/openflow/native/ovs_bridge_test_base.py

    Closes-Bug: #1992953
    Change-Id: Ibca81eb59fbfad71f223832228f408fb248c5dfa
    (cherry picked from commit 8fcf00a36dfcec80bba73b63896d806f48835faf)
    (cherry picked from commit 9d826bc77aab36dd194cc471397af68bd4ad39e5)
    (cherry picked from commit 32a8b2d3388b0e1ed4b19a5f3b68a99762f9f70b)
    (cherry picked from commit b662fd25773647259f0e8c197beafa6a5ca385d4)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/861623
Committed: https://opendev.org/openstack/neutron/commit/0889dda9904dc67578678b75936b055a9cfcbb1e
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit 0889dda9904dc67578678b75936b055a9cfcbb1e
Author: Slawek Kaplonski <email address hidden>
Date: Fri Oct 14 11:58:02 2022 +0200

    Disable in-band management for bridges before setting up controllers

    Disabling in-band management for bridge will effectively disable it for
    all controllers which are or will be set for the bridge. This will
    prevent us from having short time between configuring controller and
    setting connection_mode of the controller to "out-of-band" when
    controller works in the default "in-band" connection mode and adds some
    hidden flows to the bridge.

    Closes-Bug: #1992953
    Change-Id: Ibca81eb59fbfad71f223832228f408fb248c5dfa
    (cherry picked from commit 8fcf00a36dfcec80bba73b63896d806f48835faf)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/861708
Committed: https://opendev.org/openstack/neutron/commit/55564befea3c7d827691694963f54dbf834d1fad
Submitter: "Zuul (22348)"
Branch: stable/stein

commit 55564befea3c7d827691694963f54dbf834d1fad
Author: Slawek Kaplonski <email address hidden>
Date: Fri Oct 14 11:58:02 2022 +0200

    Disable in-band management for bridges before setting up controllers

    Disabling in-band management for bridge will effectively disable it for
    all controllers which are or will be set for the bridge. This will
    prevent us from having short time between configuring controller and
    setting connection_mode of the controller to "out-of-band" when
    controller works in the default "in-band" connection mode and adds some
    hidden flows to the bridge.

    Conflicts:
        neutron/plugins/ml2/drivers/openvswitch/agent/openflow/native/ovs_bridge.py
        neutron/tests/functional/agent/test_ovs_lib.py
        neutron/tests/unit/plugins/ml2/drivers/openvswitch/agent/openflow/native/ovs_bridge_test_base.py

    Closes-Bug: #1992953
    Change-Id: Ibca81eb59fbfad71f223832228f408fb248c5dfa
    (cherry picked from commit 8fcf00a36dfcec80bba73b63896d806f48835faf)
    (cherry picked from commit 9d826bc77aab36dd194cc471397af68bd4ad39e5)
    (cherry picked from commit 32a8b2d3388b0e1ed4b19a5f3b68a99762f9f70b)
    (cherry picked from commit b662fd25773647259f0e8c197beafa6a5ca385d4)
    (cherry picked from commit d163bf7e4a1ca34eb9cbcd7ee408026fb4aca127)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 18.6.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron stein-eol release.

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Slawek Kaplonski <email address hidden>" on branch: stable/rocky
Review: https://review.opendev.org/c/openstack/neutron/+/861626
Reason: Rocky is EOL now

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Slawek Kaplonski <email address hidden>" on branch: stable/queens
Review: https://review.opendev.org/c/openstack/neutron/+/861627
Reason: Queens is EOL now

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 19.5.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 22.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 20.3.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 21.1.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron train-eol release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron ussuri-eol release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron victoria-eom release.