[ovn-octavia-provider] LS has LB leftover after being removed from the router

[Luis Tomas Bolivar]

In order to have ovn-lb properly configured it is needed to include the loadbalancer in all the logical_switches connected to the logical_router where the VIP and the members are connected to.

With that, in the next scenario:
- LR1
- LS1 and LS2 connected to LR1
- OVN-LB1 with VIP and the members on LS1

The LB is added to both LR1, and LS1 and LS2. However, if LS2 is detached from the LR1, the OVN-LB1 remains added to the LS2 while it should be removed

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/860779

[Luis Tomas Bolivar (ltomasbo)]

The problem happens when the network where the VIP and members are is dual stack, as the ovn router will have still have the port for the other subnet (e.g., ipv6), pointing to the same network, which is used for referencing the LS

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/860779
Committed: https://opendev.org/openstack/ovn-octavia-provider/commit/464cb97fadd7134814cadd171b4de8cd2eda530e
Submitter: "Zuul (22348)"
Branch: master

commit 464cb97fadd7134814cadd171b4de8cd2eda530e
Author: Luis Tomas Bolivar <email address hidden>
Date: Mon Oct 10 17:13:27 2022 +0200

    Ensure LB are removed from LS not connected to the LB LR

    Once the logical_switch (neutron subnet) is removed from the
    logical_router (neutron router) where the OVN-LB VIP and members
    are connected to, there is no need to keep the LB added to that
    logical_switch

    Closes-Bug: #1992356
    Change-Id: I86aba3eee88b3da3cae7b57da2eabc6c3cb5d953

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/zed
Review: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/861293

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/861294

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/861295

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/861296

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/861297

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/861330

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/861330
Committed: https://opendev.org/openstack/ovn-octavia-provider/commit/8b3e5a134e2f638a3b0a02274148f5ac49443d08
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit 8b3e5a134e2f638a3b0a02274148f5ac49443d08
Author: Luis Tomas Bolivar <email address hidden>
Date: Fri Oct 14 08:35:13 2022 +0200

    Ensure LB are removed from LS not connected to the LB LR

    Once the logical_switch (neutron subnet) is removed from the
    logical_router (neutron router) where the OVN-LB VIP and members
    are connected to, there is no need to keep the LB added to that
    logical_switch

    (manually-cherry picked from commit 464cb97fadd7134814cadd171b4de8cd2eda530e)

    Closes-Bug: #1992356
    Change-Id: I86aba3eee88b3da3cae7b57da2eabc6c3cb5d953
    (cherry picked from commit 464cb97fadd7134814cadd171b4de8cd2eda530e)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/861297
Committed: https://opendev.org/openstack/ovn-octavia-provider/commit/361f2ca155fff5107c4ae6bd5cd5b6673c84ec88
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit 361f2ca155fff5107c4ae6bd5cd5b6673c84ec88
Author: Luis Tomas Bolivar <email address hidden>
Date: Mon Oct 10 17:13:27 2022 +0200

    Ensure LB are removed from LS not connected to the LB LR

    Once the logical_switch (neutron subnet) is removed from the
    logical_router (neutron router) where the OVN-LB VIP and members
    are connected to, there is no need to keep the LB added to that
    logical_switch

    Closes-Bug: #1992356
    Change-Id: I86aba3eee88b3da3cae7b57da2eabc6c3cb5d953
    (cherry picked from commit 464cb97fadd7134814cadd171b4de8cd2eda530e)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/861296
Committed: https://opendev.org/openstack/ovn-octavia-provider/commit/dc50d14a1f1c71f64c731ef5040ff51ef7a92c8e
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit dc50d14a1f1c71f64c731ef5040ff51ef7a92c8e
Author: Luis Tomas Bolivar <email address hidden>
Date: Mon Oct 10 17:13:27 2022 +0200

    Ensure LB are removed from LS not connected to the LB LR

    Once the logical_switch (neutron subnet) is removed from the
    logical_router (neutron router) where the OVN-LB VIP and members
    are connected to, there is no need to keep the LB added to that
    logical_switch

    Closes-Bug: #1992356
    Change-Id: I86aba3eee88b3da3cae7b57da2eabc6c3cb5d953
    (cherry picked from commit 464cb97fadd7134814cadd171b4de8cd2eda530e)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/861295
Committed: https://opendev.org/openstack/ovn-octavia-provider/commit/25ab8ba20f27223a33e254c285630ecd5ad18e35
Submitter: "Zuul (22348)"
Branch: stable/xena

commit 25ab8ba20f27223a33e254c285630ecd5ad18e35
Author: Luis Tomas Bolivar <email address hidden>
Date: Mon Oct 10 17:13:27 2022 +0200

    Ensure LB are removed from LS not connected to the LB LR

    Once the logical_switch (neutron subnet) is removed from the
    logical_router (neutron router) where the OVN-LB VIP and members
    are connected to, there is no need to keep the LB added to that
    logical_switch

    Closes-Bug: #1992356
    Change-Id: I86aba3eee88b3da3cae7b57da2eabc6c3cb5d953
    (cherry picked from commit 464cb97fadd7134814cadd171b4de8cd2eda530e)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/861294
Committed: https://opendev.org/openstack/ovn-octavia-provider/commit/662c9d1558f170421ac68947ccbc333baa73fa52
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit 662c9d1558f170421ac68947ccbc333baa73fa52
Author: Luis Tomas Bolivar <email address hidden>
Date: Mon Oct 10 17:13:27 2022 +0200

    Ensure LB are removed from LS not connected to the LB LR

    Once the logical_switch (neutron subnet) is removed from the
    logical_router (neutron router) where the OVN-LB VIP and members
    are connected to, there is no need to keep the LB added to that
    logical_switch

    Closes-Bug: #1992356
    Change-Id: I86aba3eee88b3da3cae7b57da2eabc6c3cb5d953
    (cherry picked from commit 464cb97fadd7134814cadd171b4de8cd2eda530e)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/861293
Committed: https://opendev.org/openstack/ovn-octavia-provider/commit/e4e671b59604d8a435ce3354cd203eaf364cd568
Submitter: "Zuul (22348)"
Branch: stable/zed

commit e4e671b59604d8a435ce3354cd203eaf364cd568
Author: Luis Tomas Bolivar <email address hidden>
Date: Mon Oct 10 17:13:27 2022 +0200

    Ensure LB are removed from LS not connected to the LB LR

    Once the logical_switch (neutron subnet) is removed from the
    logical_router (neutron router) where the OVN-LB VIP and members
    are connected to, there is no need to keep the LB added to that
    logical_switch

    Closes-Bug: #1992356
    Change-Id: I86aba3eee88b3da3cae7b57da2eabc6c3cb5d953
    (cherry picked from commit 464cb97fadd7134814cadd171b4de8cd2eda530e)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ovn-octavia-provider 1.0.2 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/networking-ovn train-eol release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ovn-octavia-provider 1.2.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ovn-octavia-provider 4.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ovn-octavia-provider 2.1.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ovn-octavia-provider 3.1.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ovn-octavia-provider ussuri-eol release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ovn-octavia-provider victoria-eom release.