machine.action does not always throw errors for failed machines
Bug #1991795 reported by
Peter Makowski
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
MAAS |
Fix Released
|
High
|
Unassigned |
Bug Description
Currently the websocket API responds to machine.action performed with a filter only with a number of nodes that the action was performed on successfully, even if an action could not be performed on some of the nodes requested (e.g. when trying an action that's not supported, like test on a machine that's already being tested).
request: request_id: 25, method: "machine.action", params: {action: "test", filter: {id: ["tw8pfr", "b3ye4t"]}}
response: { request_id: 25, result: 1 }
We need either an error message or a list of failed machines to be added to the response (system_ids/names).
Related branches
~adam-collard/maas:websocket-action-failed-ids
Merged
into
maas:master
- MAAS Lander: Approve
- Alexsander de Souza: Approve
-
Diff: 115 lines (+38/-13)2 files modifiedsrc/maasserver/websockets/handlers/machine.py (+15/-4)
src/maasserver/websockets/handlers/tests/test_machine.py (+23/-9)
Changed in maas: | |
status: | New → Triaged |
importance: | Undecided → High |
Changed in maas: | |
milestone: | none → 3.3.0 |
status: | Triaged → Fix Committed |
Changed in maas: | |
milestone: | 3.3.0 → 3.3.0-beta1 |
Changed in maas: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.