neutron

Neutron-dynamic-routing: misuse of assertTrue

Bug #1989254 reported by Takashi Natsume
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Undecided
Takashi Natsume

Bug Description

There is a misuse of assertTrue in the neutron-dynamic-routing master (commit ddac34b3845a261d7c12cc37bf053948f6a3cfb9).

neutron_dynamic_routing/tests/unit/db/test_bgp_dragentscheduler_db.py:83-84

            self.assertTrue(bgp_speaker_id,
                            res['bgp_speakers'][0]['id'])

See original description
Tags: l3-bgp
Takashi Natsume (natsume-takashi)
Changed in neutron:
assignee: nobody → Takashi Natsume (natsume-takashi)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron-dynamic-routing (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron-dynamic-routing/+/856900

Changed in neutron:
status: New → In Progress
Dr. Jens Harbott (j-harbott)
tags: added: l3-bgp
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron-dynamic-routing (master)

Reviewed: https://review.opendev.org/c/openstack/neutron-dynamic-routing/+/856900
Committed: https://opendev.org/openstack/neutron-dynamic-routing/commit/1c15cd1bc594201dc5cc1dc3593ee7264c8759e2
Submitter: "Zuul (22348)"
Branch: master

commit 1c15cd1bc594201dc5cc1dc3593ee7264c8759e2
Author: Takashi Natsume <email address hidden>
Date: Sat Sep 10 22:12:50 2022 +0900

    Fix misuse of assertTrue

    Replace assertTrue with assertEqual.

    Change-Id: I0f0b6e5a7a4b7799ecda2fcc5b5179c0f97fd44f
    Closes-Bug: 1989254
    Signed-off-by: Takashi Natsume <email address hidden>

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron-dynamic-routing 21.0.0.0rc1

This issue was fixed in the openstack/neutron-dynamic-routing 21.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.